Implement hot reloading for the locale files during development #5050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
absidue
requested review from
PikachuEXE,
efb4f5ff-1298-471a-8973-3d47447115dc,
ChunkyProgrammer,
jasonhenriquez and
MarmadileManteater
github-actions
bot
added
PR: dependencies
| const message = JSON.parse(event.data) | ||
|
|
||
| if (message.type === 'freetube-locale-update') { | ||
| const i18n = document.getElementById('app').__vue__.$i18n |
There was a problem hiding this comment.
There's so much I don't know. This is so cool. Side tip I found from looking this up for @ChunkyProgrammer: the Vue 3 equivalent is apparently __vueParentComponent.ctx.
jasonhenriquez
approved these changes
May 4, 2024
PikachuEXE
approved these changes
May 4, 2024
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
May 14, 2024
github-actions
bot
removed
the
PR: waiting for review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement hot reloading for the locale files during development
Pull Request Type
Description
This pull request implements hot reloading for the locale files. I recommend reviewing this pull request by commit, so that it's easier to understand what changes are related to what.
Currently we have it setup to reload the entire app when a locale file is edited, which is not ideal for multiple reasons, a major one being that we have to load all the data from the databases again like we do at startup and all the caches get cleared.
What is hot reloading?
You know when you edit one of the Vue or JavaScript files and it only reloads the parts of the app that changed, that's hot reloading.
Please keep in mind that not all parts of the app react to changes to the locales, the same bits that don't automatically change when you change the language won't change here either, but you can just use the backwards and forwards arrows in the navigation bar, then which still avoids the full reload.
Testing
The easiest way to test that it works is to edit the
Search / Go to URL: Search / Go to URLstring in the language that you currently have selected, as that is the text that is shown in the search bar at the top of the window that is visible on all pages.Desktop