Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make adding duplicate disabled by default #5044

Draft
wants to merge 3 commits into
base: development
Choose a base branch
from
Draft

Make adding duplicate disabled by default #5044

wants to merge 3 commits into from

Conversation

PikachuEXE
Copy link
Collaborator

@PikachuEXE PikachuEXE commented Apr 30, 2024 •
edited

Pull Request Type

  • Bugfix
  • Feature Implementation
  • Documentation
  • Other

Related issue

Closes #4818

Description

Disable adding duplicate videos to playlists by default (cannot select playlists with all to be added videos already present)
Can be enabled via new toggle only visible on prompt when any duplicate detected

Screenshots

Nothing changed for video when absent in all playlists, only screenshots of adding video(s) with some/all already present in playlists

Adding single video
image

Adding multiple videos (duplicate disallowed)
image

Adding multiple videos (duplicate allowed)
image

Testing

(A) Add one video
(A1) Video absent from all playlists
(A2) Video present in some playlists
(B) Add multiple videos
(B1) Videos absent from all playlists
(B2) Some but not all videos present in some playlists
(B3) All videos present in some playlists

Desktop

  • OS:
  • OS Version:
  • FreeTube version:

Additional context

Style/UI/Text not finalized

@PikachuEXE PikachuEXE force-pushed the feature/playlists/no-duplicate-added-by-default branch from 552b912 to 2b282e1 Compare April 30, 2024 02:39
@efb4f5ff-1298-471a-8973-3d47447115dc
Copy link
Member

Yeah not sure about the placement of that. The Add to Playlist prompt is already very overcrowded as is. Also still not sure if we should go this way at all

@PikachuEXE
Copy link
Collaborator Author

The idea is that user need to be able to enable the option before potentially tabbing into the playlists so they can select the potentially disabled playlist(s) instead of finding out playlists disabled and go back to enable it

No idea where to place it best

@jasonhenriquez
Copy link
Collaborator

jasonhenriquez commented May 4, 2024 •
edited

Could you justify the three controls at the top all next to each other on the right? It's not a perfect solution for now, but we can reassess in the future.

@PikachuEXE
Copy link
Collaborator Author

Here is my imagined flow:

  1. Enter query text
  2. Optionally search for playlists with matching video title instead of just matching playlist names
  3. Optionally realize that it's already added but want to add duplicate anyway
  4. Sort it when playlist cannot be found

Ideally it should be (4) then (3) but it might look strange if there is an extra row just for one toggle on desktop
image

@jasonhenriquez
Copy link
Collaborator

Sorry, to clarify, I mean right-justify the controls so they're grouped

@PikachuEXE
Copy link
Collaborator Author

Like this?
image
image

@PikachuEXE PikachuEXE force-pushed the feature/playlists/no-duplicate-added-by-default branch from 2b282e1 to f76c50f Compare May 5, 2024 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonhenriquez jasonhenriquez jasonhenriquez left review comments

@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc Awaiting requested review from efb4f5ff-1298-471a-8973-3d47447115dc

At least 3 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
PR: WIP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@PikachuEXE @efb4f5ff-1298-471a-8973-3d47447115dc @jasonhenriquez