Add MQTT Mutual Auth on QEMU demo #936
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonpcarroll
previously approved these changes
Feb 24, 2023
|
The files in |
There was a problem hiding this comment.
Thank you @ydhuang28 for this PR.
I have a few comments - can you please take a look?
Thanks,
FreeRTOS-Plus/Demo/MQTT_Mutual_Auth_Qemu_mps2/source/main_networking.c
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Hello @ydhuang28,
Apologies for a very delayed review. Can you please take a look at some of the minor corrections that I have suggested?
Thank you!
|
/bot run formatting |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add MQTT Mutual Auth on QEMU demo
Description
Adds a demo for MQTT Mutual Auth on QEMU.
Test Steps
n/a (see README.md in demo folder for instructions to build and test)
Checklist:
Related Issue
n/a
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.