Run VeriFast proofs in CI #845
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karkhaz
force-pushed
the
kk-fix-verifast-proofs
branch
from
45ff500
to
e31d6d9
Compare
|
CI will pass once we actually install VeriFast in CI (soon). I also need to add a README explaining the proof-configuration file |
karkhaz
force-pushed
the
kk-fix-verifast-proofs
branch
11 times, most recently
from
3aea120
to
fab90ac
Compare
karkhaz
force-pushed
the
kk-fix-verifast-proofs
branch
from
fab90ac
to
85b665d
Compare
archigup
reviewed
Sep 7, 2022
Outstanding: - xQueueGenericReset return code - Not using prvIncrementQueueTxLock or prvIncrementQueueRxLock macros
Uncrustify requires formatting of comments that is at odds with VeriFast's proof annotations, which are contained within comments.
This commit changes the run-cbmc-proofs.py script so that it also adds Litani jobs for each of the VeriFast proofs. The result of the VeriFast proofs is presented on the Litani dashboard alongside the existing CBMC proofs.
This commit removes the old Makefile for running VeriFast, and updates the documentation for how to run all proofs in parallel. It also adds an option to the run script to allow running only the VeriFast proofs.
karkhaz
force-pushed
the
kk-fix-verifast-proofs
branch
from
85b665d
to
45e0660
Compare
|
Thanks Kareem, this looks good to me (from the point-of-view of getting the VeriFast proofs happy again) |
nchong-at-aws
previously approved these changes
Sep 7, 2022
archigup
previously approved these changes
Sep 9, 2022
AniruddhaKanhere
dismissed stale reviews from archigup and nchong-at-aws
via
03f6357
AniruddhaKanhere
approved these changes
Sep 9, 2022
moninom1
pushed a commit
to moninom1/FreeRTOS
that referenced
this pull request
Jun 27, 2023
* Remove configUSE_CO_ROUTINES. * Add unit test cases for FreeRTOS_Routing. * Fix spelling. * Remove useless test cases. * Fix spelling again. * Rename Routing UT folder * Remove redundant test files. * Toggle full coverage * Code beautify * Fix UT failing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the VeriFast proofs run in CI along with the CBMC proofs. The results for both CBMC and VeriFast proofs are displayed on a single Litani dashboard.
This PR incorporates #836, which fixes whitespace changes in the VeriFast proofs.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.