DNS local lookups using mDNS repaired #1118
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Somewhere along the way, active lookups using mDNS got broken.
When a peer answers an mDNS a lookup, in its answer, it will not repeat the questions that were asked by the client.
Test Steps
I did 3 kinds of lookups, each of them in 4 different ways:
A normal DNS lookup
A mDNS lookup of
laptop-hp.local
An LLMNR lookup of
laptop-hp
I repeated each lookup by either asking for A or for AAAA records. Also I would either use IPv4 or IPv6 to contact the peer/server, setting
xDNS_IP_Preference
.Here are the results of of mDNS/LLMNR tests:
DNS_tests.zip
Without the reparation, mDNS would not succeed.
Checklist:
Related Issue
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.