Rename ARM_CA53_64_BIT/_SRE to Arm_AARCH64/_SRE #822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
urutva
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #822 +/- ##
=======================================
Coverage 93.64% 93.64%
=======================================
Files 6 6
Lines 2549 2549
Branches 608 608
=======================================
Hits 2387 2387
Misses 107 107
Partials 55 55
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Skptak
previously approved these changes
Oct 19, 2023
Skptak
reviewed
Oct 19, 2023
portable/GCC/README.md
Outdated
Comment on lines
12
to
13
| the T32 and A32 instruction sets. Follow the [link](https://developer.arm.com/Architectures/A-Profile%20Architecture) | ||
| for more information. |
There was a problem hiding this comment.
Suggested change
| the T32 and A32 instruction sets. Follow the [link](https://developer.arm.com/Architectures/A-Profile%20Architecture) | |
| for more information. | |
| the T32 and A32 instruction sets. Follow the | |
| [link](https://developer.arm.com/Architectures/A-Profile%20Architecture) | |
| for more information. |
AniruddhaKanhere
previously approved these changes
Oct 19, 2023
The Cortex-A53 ports are generic and can be used as a starting point for other Armv8-A application processors. Therefore, rename `ARM_CA53_64_BIT` to `Arm_AARCH64` and `ARM_CA53_64_BIT_SRE` to `Arm_AARCH64_SRE`. With this renaming, existing projects that use old port, should migrate to renamed port as follows: * `ARM_CA53_64_BIT` -> `Arm_AARCH64` * `ARM_CA53_64_BIT_SRE` -> `Arm_AARCH64_SRE` Signed-off-by: Devaraj Ranganna <devaraj.ranganna@arm.com>
urutva
force-pushed
the
rename-ca53-to-aarch64
branch
from
c8be7db
to
54b3b75
Compare
aggarg
approved these changes
Oct 23, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
chinglee-iot
approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The Cortex-A53 ports are generic and can be used as a starting point for other Armv8-A application processors. Therefore, rename
ARM_CA53_64_BITtoArm_AARCH64andARM_CA53_64_BIT_SREtoArm_AARCH64_SRE.With this renaming, existing projects that use old port, should migrate to renamed port as follows:
ARM_CA53_64_BIT->Arm_AARCH64ARM_CA53_64_BIT_SRE->Arm_AARCH64_SRETest Steps
There are no functional changes.
Checklist:
Related Issue
#565
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.