Fix build errors with Python 3.13 #5208
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to [1], the `PyEval_InitThreads()` (deprecated 3.9), `PyEval_AcquireLock()` and `PyEval_ReleaseLock()` (deprecated 3.2). functions, are removed in Python 3.13. `Py_SetProgramName()` is deprecated since 3.11 as well. `PyEval_InitThreads` can be deleted if running Python >= 3.10 as it simply does nothing from Python 3.9 [2]. Lock functions are replaced with `PyEval_RestoreThread` and `PyEval_SaveThread` as advised by Python docs [3], [4]. As for `Py_SetProgramName`, it should be replaced with PyConfig. The config is isolated to replicate behavior of `InitializeEx` [5]. [1]: https://docs.python.org/3.13/whatsnew/3.13.html [2]: https://docs.python.org/3/c-api/init.html#c.PyEval_InitThreads [3]: https://docs.python.org/3/c-api/init.html#c.PyEval_AcquireLock [4]: https://docs.python.org/3/c-api/init.html#c.PyEval_ReleaseLock [5]: https://docs.python.org/3/c-api/init_config.html#isolated-configuration
alandekok
added a commit
that referenced
this pull request
Jan 18, 2024
|
I've done some formatting and cleanups. Please double-check. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to 1, the
PyEval_InitThreads()(deprecated 3.9),PyEval_AcquireLock()andPyEval_ReleaseLock()(deprecated 3.2). functions, are removed in Python 3.13.Py_SetProgramName()is deprecated since 3.11 as well.PyEval_InitThreadscan be deleted if running Python >= 3.10 as it simply does nothing from Python 3.9 2.Lock functions are replaced with
PyEval_RestoreThreadandPyEval_SaveThreadas advised by Python docs 3, 4.As for
Py_SetProgramName, it should be replaced with PyConfig. The config is isolated to replicate behavior ofInitializeEx5.