V3.0.x cdp #4992
Open
V3.0.x cdp #4992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natarajanmm
commented
May 11, 2023
natarajanmm
commented
…ephemeral child were actual processing happens) unlike UDP. Stats need to update parent incase of TCP and also find socket to update didn't look for TCP sockets. Addressed both these.
…ilable as an attribute helps in certain use cases in python plugin, currently this attribute from certificate isn't parsesd. Added support to parse this from the certificate.
lytboris
reviewed
May 12, 2023
src/main/tls.c
Outdated
| if (crl_dp != NULL) { | ||
| for (int i = 0; i < sk_DIST_POINT_num(crl_dp); i++) { | ||
| dp = sk_DIST_POINT_value(crl_dp, i); | ||
| if (dp != NULL) { |
There was a problem hiding this comment.
Too many nested if's. Consider using continue when dp == NULL
src/main/tls.c
Outdated
| if (dp != NULL) { | ||
| cdp[0] = '\0'; | ||
| url_ptr = get_dp_url(dp); | ||
| if (url_ptr != NULL) { |
There was a problem hiding this comment.
Addressed both the comments
|
We won't merge this into v3.0.x. That branch is for security issues and bug fixes only. There are no new features in 3.0. We will take a look at adding these features in 3.2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.