Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TCP Support #64

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

aravindprasads
Copy link

By Default, only UDP is used as transport protocol for RADIUS Messages in FreeRADIUS Client.

Since FreeRADIUS Server has started supporting TCP in latest releases, added TCP support to FreeRADIUS Client to utilize the feature.

Also, the choice of the transport protocol to be used for RADIUS messages is made configurable to user via the configuration file and all the existing interfaces of FreeRADIUS Client remain unchanged.

@alandekok
Copy link
Member

Stop opening new pull requests. It's. It necessary. And it is annoying.

Just do a force push to your branch, and the issue will be updated with your changes

Sent from my iPhone

On Sep 11, 2015, at 3:26 PM, prasad90 notifications@github.com wrote:

By Default, only UDP is used as transport protocol for RADIUS Messages in FreeRADIUS Client.

Since FreeRADIUS Server has started supporting TCP in latest releases, added TCP support to FreeRADIUS Client to utilize the feature.

Also, the choice of the transport protocol to be used for RADIUS messages is made configurable to user via the configuration file and all the existing interfaces of FreeRADIUS Client remain unchanged.

You can view, comment on, or merge this pull request online at:

#64

Commit Summary

TCP Support
File Changes

M etc/radiusclient.conf.in (5)
M include/freeradius-client.h (5)
M lib/buildreq.c (7)
M lib/options.h (1)
M lib/sendserver.c (14)
Patch Links:

https://github.com/FreeRADIUS/freeradius-client/pull/64.patch
https://github.com/FreeRADIUS/freeradius-client/pull/64.diff

Reply to this email directly or view it on GitHub.

@aravindprasads
Copy link
Author

Yes, Alan. Will avoid the new pull requests in future.

@arr2036
Copy link
Member

arr2036 commented Sep 11, 2015

Given the failure of the previous builds, it would be nice if you could add tests to ensure that the TCP support actually works. There are examples you can follow in the test directory.

@aravindprasads
Copy link
Author

I have added unit tests.

Does RADIUS Server used in this test files support TCP ? I have made changes to send RADIUS Messages with TCP and its failing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants