Select all checkbox

[artjomsR]

simple checkbox to make it easier to extract new words when reading multiple books

2024-04-18.23-17-54.mp4

[1over137]

Personally I would like it to not be a checkbox like all the other normal ones. Maybe a button, next to the "Select books" label would be better. I wonder if it is a common use case. I actually haven't really used it like that at all, except in testing, since I am never actively reading more than more than one book at the same time.

[artjomsR]

I wanted to do a "toggle all" button to begin with but the logic could be complicated when only some checkboxes are ticked, so it'd be cleaner to just have 2 separate buttons

VS.mov

[1over137]

I wanted to do a "toggle all" button to begin with but the logic could be complicated when only some checkboxes are ticked, so it'd be cleaner to just have 2 separate buttons

Would this not work?

checkbox.setChecked(not checkbox.isChecked())

Again my concern is that the buttons take up space for the selections

Honestly I'm not sure this is a good idea
How about instead of this, we can let the importer remember last selected options just like the dates? You should only have to change it infrequently
The idea is set a setting when an import succeeds, recording the books users selected, and auto-populate it when the user presses "repeat last import" (this will only trigger either kindle or koreader, not others).

[artjomsR]

Ok, now there's no new UI elements, the checkboxes simply keep their checked status after an import

[1over137]

don't actually store the python list in the settings, since it would be written as some QVariant binary thing. Store them with json strings (json.dumps, loads) and read them out

[1over137]

also let's just get rid of all the truncate_middle calls, because I think they cause issues with the filtering and don't really have benefits anyways (the viewport can scroll).