Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove workaround for md5sum download #407

Merged
merged 7 commits into from
Sep 11, 2023

Conversation

nathanthorpe
Copy link
Member

@nathanthorpe nathanthorpe commented Jun 16, 2022

Resolves #297 and #371

  • Bump rclone to 1.58.1 to pick up the --download flag on the rclone md5sum command
  • Fix potential command injection with the workaround (file names are not escaped)

@dtenenba
Copy link
Contributor

@nathanthorpe Can you make sure that #371 is addressed in this PR? Otherwise we will have issues when we update rclone.
You can either add --s3-no-check-bucket to the rclone copyto command line or set RCLONE_S3_NO_CHECK_BUCKET to true in the environment that the copyto command runs in.

More info at:
https://rclone.org/s3/#s3-no-check-bucket

@nathanthorpe
Copy link
Member Author

Nice good catch

@dtenenba dtenenba merged commit 4caa87d into FredHutch:master Sep 11, 2023
nathanthorpe added a commit to nathanthorpe/motuz that referenced this pull request Sep 15, 2023
dtenenba pushed a commit that referenced this pull request Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Address the hashsum --download workaround
2 participants