Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade CI to Node 18 and deprecate Node 14 #2667

Merged
merged 13 commits into from
Oct 19, 2023
Merged

Conversation

carbonrobot
Copy link
Contributor

@carbonrobot carbonrobot commented Oct 18, 2023

Upgrades the CI to default to Node 18.x and refactors the common CI setup into a reusable action.

  • Removes CI run for Node 14.x
  • Upgrades actions/checkout to v4
  • Upgrades actions/setup-node to v3

@changeset-bot
Copy link

changeset-bot bot commented Oct 18, 2023

⚠️ No Changeset found

Latest commit: dcaec36

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Oct 18, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
victory ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 19, 2023 11:57am

@gksander
Copy link
Contributor

This all looks good to me. CI is choking on the 20.x with this though:

/home/runner/work/victory/victory/node_modules/.pnpm/proper-lockfile@4.1.2/node_modules/proper-lockfile/lib/lockfile.js:213
        onCompromised: (err) => { throw err; },
                                  ^

[Error: ENOENT: no such file or directory, stat '/home/runner/work/victory/victory/packages/victory-voronoi-container/.wireit/6275696c643a6c69623a636a73/lock.lock'] {
  errno: -2,
  code: 'ECOMPROMISED',
  syscall: 'stat',
  path: '/home/runner/work/victory/victory/packages/victory-voronoi-container/.wireit/6275696c643a6c69623a636a73/lock.lock'
}

Looks like something weird going on with wireit cache. I'm going to pull this down locally and run with node 20.8.0 to see if it's something in the GH actions cache that we need to blast away.

@gksander
Copy link
Contributor

Completed just fine locally, so looks like we've got a little bit of cache investigation to undertake (and I don't think GH offers a way to e.g. "nuke all 1367 cache artifacts"), ought to be a fun little adventure.

Copy link

@carloskelly13 carloskelly13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Love the streamlining of the CI set up.

@carbonrobot carbonrobot merged commit d6b125a into main Oct 19, 2023
6 of 7 checks passed
@carbonrobot carbonrobot deleted the chore/upgrade-ci branch October 19, 2023 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants