New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix using React.ComponentProps with VictoryLine component #2547
fix: fix using React.ComponentProps with VictoryLine component #2547
Conversation
🦋 Changeset detectedLatest commit: d9e321d The changes in this PR will be included in the next version bump. This PR includes changesets to release 30 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Hi, is it possible to get some eyeballs on this PR?.. Would be great to get rid of a patch-package in our codebase 😀 |
@Waltari10 Thanks for this! We'll try and get around to this next week if we can. I'm going to add a review to get CI running and checking. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI
@scottrippey @gksander Any idea why this CI is stuck in |
I'm going to try closing and reopening this PR to see if it'll trigger GitHub Actions to send another approval request so we can get CI ran on this! |
This reverts commit 180ea8c.
We're going to have to look into why forked PRs aren't triggering approval requests for CI runs, but in the meantime – I went ahead and just pushed up a couple dummy commits to the branch to trigger the workflows. |
Closing, as this component will become a functional component soon and this will no longer be relevant. |
Looking at file
myApp/node_modules/victory-line/lib/victory-line.d.ts
file the built type file ended up with a constructor that takes props as type of any:When trying to parse the components props one ended up with
any
type forVictoryLineProps
. However inferring types for other components likeVictoryScatter
worked fine because it didn't have constructor defined in code.So in this PR just removing the constructor to avoid it getting any type. Doesn't look like the constructor is needed or used for anything anyway.