Replace lodash isString with native equivalent (#2827)

FormidableLabs · Mar 12, 2024 · 3d6f8ad · 3d6f8ad
1 parent 6f24b89
commit 3d6f8ad
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/.changeset/gorgeous-pianos-deliver.md b/.changeset/gorgeous-pianos-deliver.md
@@ -0,0 +1,5 @@
+---
+"victory-voronoi-container": patch
+---
+
+Replace lodash isString with native equivalent
diff --git a/packages/victory-voronoi-container/src/voronoi-helpers.ts b/packages/victory-voronoi-container/src/voronoi-helpers.ts
@@ -1,5 +1,5 @@
 import { Collection, Selection, Data, Helpers } from "victory-core";
-import { isEmpty, isString, isRegExp, throttle } from "lodash";
+import { isEmpty, isRegExp, throttle } from "lodash";
 import isEqual from "react-fast-compare";
 import Delaunay from "delaunay-find/lib/index.js";
 import React from "react";
@@ -66,7 +66,9 @@ class VoronoiHelpersClass {
       const childProps = child.props || {};
       const name = childProps.name || childName;
       const blacklist = props.voronoiBlacklist || [];
-      const blacklistStr = blacklist.filter(isString);
+      const blacklistStr = blacklist.filter(
+        (value) => !!value && typeof value.valueOf() === "string",
+      );
       const blacklistRegExp = blacklist.filter(isRegExp);
       const isRegExpMatch = blacklistRegExp.some((regExp) => regExp.test(name));
       if (