Added font-display: block to @font-face #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevents fork awesome from delaying page render.
Prevents fork awesome from delaying page render.
…213/pattishih/patch-1
|
Hello. Thanks a lot for this fix. Sorry for the delay in merging it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #193
font-display is a newer CSS property for the @font-face rule that enables the page to continue rendering while the resource loads in the background. By specifying the value "block," any ForkAwesome fonts will display as blanks in-place (similar to visibility: hidden) until it is ready to be rendered. While there are other values that can be specified for font-display, "block" is the most appropriate for icon fonts as there are unlikely to be any suitable local substitutes. Unsupported browsers will simply ignore the property.
References:
A demonstration of font-display: https://font-display.glitch.me
Resolved font-display issue report for FontAwesome: FortAwesome/Font-Awesome#14387
The implementation of font-display for Google Fonts: https://css-tricks.com/google-fonts-is-adding-font-display/