Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dedicated dir for database #127

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

dedicated dir for database #127

wants to merge 3 commits into from

Conversation

avilabss
Copy link

@avilabss avilabss commented Jan 2, 2024

As a resolution for issue #126, I've implemented a separation of the database and uploaded data folder into distinct directories. This modification is designed to enhance user flexibility by allowing them to effortlessly mount a NAS share in place of the data directory without introducing any complications with the database.

@Forceu
Copy link
Owner

Forceu commented Jan 2, 2024

Thank you for the pull request! Please make sure, that the tests run successfully (you might need to change some, if you have modified the database location).
Let me know if you need help at any point

@avilabss
Copy link
Author

avilabss commented Jan 2, 2024

Can you send some instructions on how to set this project up locally for development?
Since the changes I made were kinda small, I just tested it by running the whole thing in docker but that won't cut it for doing proper tests.

@Forceu
Copy link
Owner

Forceu commented Jan 2, 2024

Simply clone the repository and execute go test ./... -parallel 8 --tags=test,awsmock in the top folder.

However if you are using Docker, it might be easier to simply mount the database file? You can mount single files as well, not just folders

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants