[MIRROR] [no gbp] Fixes deathmatch observers #3127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* [no gbp] Fixes deathmatch observers (#82931) ## About The Pull Request Got a little ahead of myself. My apologies. Fixes some cases in the deathmatch UI that cause blue screens / improper perms. I've also made deathmatch send an actual array rather than an object. Don't make javascript iterate object.keys please. Fixed the types surrounding this. ## Why It's Good For The Game Fixes #82926 ## Changelog :cl: fix: Fixes a bluescreen in the deathmatch lobby UI. /:cl: * [no gbp] Fixes deathmatch observers --------- Co-authored-by: Jeremiah <42397676+jlsnow301@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Nova: NovaSector/NovaSector#2256
Original PR: tgstation/tgstation#82931
About The Pull Request
Got a little ahead of myself. My apologies. Fixes some cases in the deathmatch UI that cause blue screens / improper perms.
I've also made deathmatch send an actual array rather than an object. Don't make javascript iterate object.keys please. Fixed the types surrounding this.
Why It's Good For The Game
Fixes #82926
Changelog
馃啈 jlsnow301
fix: Fixes a bluescreen in the deathmatch lobby UI.
/:cl: