Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] A birdshot atmos improvement, and fixes the engineering microwave. #3125

Merged
merged 1 commit into from
Apr 30, 2024

Conversation

Steals-The-PRs
Copy link
Collaborator

Mirrored on Nova: NovaSector/NovaSector#2254
Original PR: tgstation/tgstation#82924

About The Pull Request

I have changed the layout of the pumps going into atmos from the tanks to make it easier to use.
image
image
I also fixed the engineering microwave.
I also adjusted the name for the pumps and vents in the AI chamber.

This is my first PR!

Why It's Good For The Game

This change allow people to easily set up a pump to fill up a can with the gas they want. Before this it was impossible to fill up an n2o can and a plasma can without making a big mess or having them mix together.

The microwave in engi being able to work is also a good quality of life change for the poor engineers that want to cook a donk pocket in their department.

The change of names for the vents and pumps in the AI chamber is for consistency sake. n2o is not helium!

Changelog

🆑 Constellado
qol: Made birdshot atmos easier to use.
fix: The Birdshot engineering department is no longer using a second hand broken microwave.
/:cl:

…owave. (#2254)

* A birdshot atmos improvement, and fixes the engineering microwave. (#82924)

## About The Pull Request
I have changed the layout of the pumps going into atmos from the tanks
to make it easier to use.

![image](https://github.com/tgstation/tgstation/assets/64122807/ec95eab6-b7ac-4927-b3d9-70f7c58e5dc8)

![image](https://github.com/tgstation/tgstation/assets/64122807/571bb2f3-49c8-4b4b-9d9d-405a8d5a06eb)
I also fixed the engineering microwave.
I also adjusted the name for the pumps and vents in the AI chamber. 


This is my first PR!
## Why It's Good For The Game

This change allow people to easily set up a pump to fill up a can with
the gas they want. Before this it was impossible to fill up an n2o can
and a plasma can without making a big mess or having them mix together.

The microwave in engi being able to work is also a good quality of life
change for the poor engineers that want to cook a donk pocket in their
department.

The change of names for the vents and pumps in the AI chamber is for
consistency sake. n2o is not helium!
## Changelog
:cl:
qol: Made birdshot atmos easier to use.
fix: The Birdshot engineering department is no longer using a second
hand broken microwave.
/:cl:

* A birdshot atmos improvement, and fixes the engineering microwave.

---------

Co-authored-by: Constellado <64122807+Constellado@users.noreply.github.com>
@mogeoko mogeoko merged commit 8511cdf into master Apr 30, 2024
27 checks passed
@mogeoko mogeoko deleted the upstream-mirror-2254 branch April 30, 2024 22:22
AnywayFarus added a commit that referenced this pull request Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants