Reinclude netlify cli dependency to fix docs build #2041
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Whilst this has fixed the initial push/build of the documentation, now, no incremental changes are recognised and updated locally. |
|
Have opened #2045 as an alternative fix. |
|
Closing as better fix was merged in #2045 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem
Running the website locally was only copying over ~40% of the documentation, making writing (and checking) effective documentation impossible.
Solution
Managed to track the issue down to this PR: 4fd2cd5
The only things that made sense as to maybe having an impact was the change to the
dev:commands and the dependency on thenetlify-cli, why this impact thecopy_docs.jsfile - I have no idea, couldn't understand the why, but re-including this library and running the website fromdev:netlifyresolves the documentation problems.