Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

blog: exploring node-red-dashboard 2.0 widgets #1979

Merged
merged 52 commits into from
May 27, 2024
Merged

blog: exploring node-red-dashboard 2.0 widgets #1979

merged 52 commits into from
May 27, 2024

Conversation

sumitshinde-84
Copy link
Collaborator

@sumitshinde-84 sumitshinde-84 commented Apr 29, 2024 •
edited

Description

Related Issue(s)

closes https://github.com/FlowFuse/customer/issues/151

Checklist

  • I have read the contribution guidelines
  • I have considered the performance impact of these changes
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated

@github-actions GitHub Actions
Copy link
Contributor

Images automagically compressed by Calibre's image-actions ✨

Compression reduced images by 36%, saving 166.12 KB.

Filename Before After Improvement Visual comparison
src/blog/2024/04/images/exploring-dashboard-2-widgets-change-node.png 16.52 KB 10.13 KB -38.6% View diff
src/blog/2024/04/images/exploring-dashboard-2-widgets-chart-widget.png 38.55 KB 23.37 KB -39.4% View diff
src/blog/2024/04/images/exploring-dashboard-2-widgets-dropdown-widget.png 53.01 KB 32.00 KB -39.6% View diff
src/blog/2024/04/images/exploring-dashboard-2-widgets-expense-submission-form.png 50.29 KB 31.76 KB -36.8% View diff
src/blog/2024/04/images/exploring-dashboard-2-widgets-income-expense-tracker-system-node-red-flow.png 142.73 KB 97.07 KB -32.0% View diff
src/blog/2024/04/images/exploring-dashboard-2-widgets-income-submission-form.png 46.63 KB 29.79 KB -36.1% View diff
src/blog/2024/04/images/exploring-dashboard-2-widgets-notification-widget.png 35.27 KB 20.41 KB -42.1% View diff
src/blog/2024/04/images/exploring-dashboard-2-widgets-table-widget.png 19.12 KB 11.56 KB -39.5% View diff
src/blog/2024/04/images/exploring-dashboard-2-widgets-template-widget.png 59.88 KB 39.79 KB -33.5% View diff

997 images did not require optimisation.

ZJvandeWeg
ZJvandeWeg reviewed May 14, 2024
View reviewed changes
src/blog/2024/04/exploring-node-red-dashboard-2-widgets.md Outdated

If you want to enhance this simple application by adding more features or want to make the application personalize for users, consider the following resources:

[Webinar](https://flowfuse.com/webinars/2024/node-red-dashboard-multi-user/) - This webinar provides an in-depth discussion of the Personalised Multi-User Dashboards feature and offers guidance on how to get started with it.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove https://flowfuse.com for internal links

@ZJvandeWeg
Copy link
Member

@sumitshinde-84 What's the status of this post?

@sumitshinde-84
Copy link
Collaborator Author

What's the status of this post?

I have a lot of changes to make to the flow. It will be ready before tomorrow evening.

@github-actions GitHub Actions
Copy link
Contributor

Images automagically compressed by Calibre's image-actions ✨

Compression reduced images by 35.5%, saving 27.57 KB.

Filename Before After Improvement Visual comparison
src/blog/2024/05/images/exploring-dashboard-2-widgets-change-node.png 21.53 KB 13.35 KB -38.0% View diff
src/blog/2024/05/images/exploring-dashboard-2-widgets-template-widget.png 56.17 KB 36.78 KB -34.5% View diff

1008 images did not require optimisation.

@sumitshinde-84 sumitshinde-84 marked this pull request as ready for review May 16, 2024 09:08
@ZJvandeWeg ZJvandeWeg requested a review from joepavitt May 16, 2024 12:22
@sumitshinde-84 sumitshinde-84 mentioned this pull request May 16, 2024
Closed
@sumitshinde-84 sumitshinde-84 linked an issue May 16, 2024 that may be closed by this pull request
Blog Art : Exploring node-red-dashboard 2.0 widgets #2071
Closed
@joepavitt
Copy link
Contributor

Noting that this still needs an article tile before merging - fyi @Yndira-E - #2071

Noticed that the art request doesn't have a deadline on it, so that's likely why it wasn't scheduled. In the future @sumitshinde-84 feel free to add one. in, although I guess this is also discussed in the #dept-customer calls?

@Yndira-E
Copy link
Contributor

Thanks @joepavitt for the reminder, I had missed it, sorry about that! I'll work on it on Monday.

If this is ready feel free to approve and I'll merge it when I add the image 😉

joepavitt
joepavitt requested changes May 24, 2024
View reviewed changes
Copy link
Contributor

@joepavitt joepavitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Slight re-phrasing of the opening
  • Fixed a comma < > full stop mistake
  • Adding in captions to images will make the article a lot easier to parse/read

src/blog/2024/05/exploring-node-red-dashboard-2-widgets.md Outdated Show resolved Hide resolved
src/blog/2024/05/exploring-node-red-dashboard-2-widgets.md Show resolved Hide resolved
src/blog/2024/05/exploring-node-red-dashboard-2-widgets.md Show resolved Hide resolved
src/blog/2024/05/exploring-node-red-dashboard-2-widgets.md Show resolved Hide resolved
src/blog/2024/05/exploring-node-red-dashboard-2-widgets.md Show resolved Hide resolved
src/blog/2024/05/exploring-node-red-dashboard-2-widgets.md Show resolved Hide resolved
src/blog/2024/05/exploring-node-red-dashboard-2-widgets.md Show resolved Hide resolved
src/blog/2024/05/exploring-node-red-dashboard-2-widgets.md Show resolved Hide resolved
src/blog/2024/05/exploring-node-red-dashboard-2-widgets.md Show resolved Hide resolved
src/blog/2024/05/exploring-node-red-dashboard-2-widgets.md Outdated Show resolved Hide resolved
@sumitshinde-84 @joepavitt
Apply suggestions from code review
30ae59b 
Co-authored-by: Joe Pavitt <99246719+joepavitt@users.noreply.github.com>
@sumitshinde-84
Copy link
Collaborator Author

Noting that this still needs an article tile before merging - fyi @Yndira-E - #2071

Noticed that the art request doesn't have a deadline on it, so that's likely why it wasn't scheduled. In the future @sumitshinde-84 feel free to add one. in, although I guess this is also discussed in the #dept-customer calls?

Okay @joepavitt, I will make sure to add a deadline next time.

@Yndira-E Yndira-E force-pushed the Node-RED-Dashboard-2-widgets-Crash-Course branch from 26da894 to 24329c4 Compare May 27, 2024 08:30
@Yndira-E Yndira-E requested a review from ZJvandeWeg May 27, 2024 08:33
@github-actions GitHub Actions
Copy link
Contributor

Images automagically compressed by Calibre's image-actions ✨

Compression reduced images by 5.7%, saving 9.07 KB.

Filename Before After Improvement Visual comparison
src/blog/2024/05/images/dashboard-widgets.png 158.43 KB 149.36 KB -5.7% View diff

1021 images did not require optimisation.

@Yndira-E
Copy link
Contributor

@ZJvandeWeg, I was about to merge this but noticed that you haven't approved it yet, so I have re-requested your review.

@ZJvandeWeg
Copy link
Member

As Joe approved, no need to wait for me.

@ZJvandeWeg ZJvandeWeg merged commit 9e49439 into main May 27, 2024
4 checks passed
@ZJvandeWeg ZJvandeWeg deleted the Node-RED-Dashboard-2-widgets-Crash-Course branch May 27, 2024 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yndira-E Yndira-E Yndira-E left review comments

@joepavitt joepavitt joepavitt approved these changes

@ZJvandeWeg ZJvandeWeg Awaiting requested review from ZJvandeWeg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Blog Art : Exploring node-red-dashboard 2.0 widgets
4 participants
@sumitshinde-84 @ZJvandeWeg @joepavitt @Yndira-E