Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CSP headers #230

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Add CSP headers #230

wants to merge 1 commit into from

Conversation

cstns
Copy link
Contributor

@cstns cstns commented Apr 30, 2024

Description

Take CSP into consideration and allows the editor to be embedded

Related Issue(s)

related to: #3801
part of: #3800

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Backport needed? -> add the backport label
  • Includes a DB migration? -> add the area:migration label

@cstns cstns requested a review from joepavitt April 30, 2024 18:16
@cstns cstns self-assigned this Apr 30, 2024
@cstns cstns changed the title wip csp Add CSP headers Apr 30, 2024
@cstns cstns marked this pull request as draft April 30, 2024 18:19
@cstns
Copy link
Contributor Author

cstns commented May 1, 2024

We may even be able to allow them to self configure and overwrite the config if needed.

The less config needed to be done by the end user, the better!

@joepavitt
Copy link
Contributor

@cstns now that you're back from holiday - what's the status on this?

@cstns
Copy link
Contributor Author

cstns commented May 8, 2024

Not looking good. Spoke with @hardillb about it and it seems it's the oauth lib that we're using is causing the issues. I also stumbled across jaredhanson/passport#938 in which the author seems to take his hands of the wheel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants