Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

324 - Allow users to set custom hostnames for instances #3830

Open
wants to merge 37 commits into
base: main
Choose a base branch
from

Conversation

hardillb
Copy link
Contributor

@hardillb hardillb commented May 7, 2024

Description

UI work for #324

Will also include the ee work

Related Issue(s)

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Backport needed? -> add the backport label
  • Includes a DB migration? -> add the area:migration label

@hardillb hardillb self-assigned this May 7, 2024
Copy link

codecov bot commented May 7, 2024

Codecov Report

Attention: Patch coverage is 20.21277% with 75 lines in your changes are missing coverage. Please review.

Project coverage is 78.96%. Comparing base (b622261) to head (e7f97ec).
Report is 27 commits behind head on main.

Files Patch % Lines
forge/ee/routes/customHostnames/index.js 12.50% 56 Missing ⚠️
forge/ee/lib/customHostnames/index.js 26.31% 14 Missing ⚠️
forge/db/models/ProjectSettings.js 25.00% 3 Missing ⚠️
forge/db/views/Project.js 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3830      +/-   ##
==========================================
- Coverage   79.28%   78.96%   -0.32%     
==========================================
  Files         281      283       +2     
  Lines       12755    12852      +97     
  Branches     2844     2864      +20     
==========================================
+ Hits        10113    10149      +36     
- Misses       2642     2703      +61     
Flag Coverage Δ
backend 78.96% <20.21%> (-0.32%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hardillb hardillb requested a review from knolleary May 29, 2024 10:47
@hardillb hardillb marked this pull request as ready for review May 29, 2024 12:05
Copy link
Member

@knolleary knolleary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some initial comments based on discussion:

  • modify the customHostname setting to be an object ('hostname:string', 'dnsVerified':boolean) - which allows us to track if the dns 'looks' okay for the provided hostname
  • add a verification step when the user sets/changes the custom hostname - see if we can check the dns for the provided hostname is properly configured
  • add UI feedback on what to set the dns entry to
    • myCustomDomain.net CNAME dns-entry.flowfuse.com (or whatever makes sense)
  • add a top level configuration to specify the subdomain assigned to the ingress entry point

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants