-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
324 - Allow users to set custom hostnames for instances #3830
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3830 +/- ##
==========================================
- Coverage 79.28% 78.96% -0.32%
==========================================
Files 281 283 +2
Lines 12755 12852 +97
Branches 2844 2864 +20
==========================================
+ Hits 10113 10149 +36
- Misses 2642 2703 +61
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some initial comments based on discussion:
- modify the customHostname setting to be an object ('hostname:string', 'dnsVerified':boolean) - which allows us to track if the dns 'looks' okay for the provided hostname
- add a verification step when the user sets/changes the custom hostname - see if we can check the dns for the provided hostname is properly configured
- add UI feedback on what to set the dns entry to
myCustomDomain.net CNAME dns-entry.flowfuse.com
(or whatever makes sense)
- add a top level configuration to specify the subdomain assigned to the ingress entry point
Description
UI work for #324
Will also include the ee work
Related Issue(s)
Checklist
flowforge.yml
?FlowFuse/helm
to update ConfigMap TemplateFlowFuse/CloudProject
to update values for Staging/ProductionLabels
backport
labelarea:migration
label