Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve cross domain communication between the app and the embedded editor #3801

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

cstns
Copy link
Contributor

@cstns cstns commented Apr 30, 2024

Description

Investigation of current setup

Related Issue(s)

closes #3800

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Backport needed? -> add the backport label
  • Includes a DB migration? -> add the area:migration label

@cstns cstns requested a review from joepavitt April 30, 2024 18:09
@cstns cstns marked this pull request as draft April 30, 2024 18:09
@cstns cstns self-assigned this Apr 30, 2024
@cstns cstns mentioned this pull request Apr 30, 2024
11 tasks
@cstns
Copy link
Contributor Author

cstns commented Apr 30, 2024

The main issue here remains chrome and other webkit browsers, firefox seems to be more lax.

The main issue that currently remains unsolved is the editor being redirected to the login page due to misplaced cookies caused by cross domains.

I left todo's in the code and a proposed solution. The problem could be easily solved by having the ability to set the sid & connect.sid cookies on custom domains and not have them on the base_url defined in the flowforge.local.yml.

I wasn't able to carry out my solution to the end because I got stuck at not being able to manipulate chrome cookies, most probably due to missing https protocol

@cstns cstns changed the title Resove cross domain communication between the app and the embedded editor Resolve cross domain communication between the app and the embedded editor Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make the embedded NR Editor work in a cross domain-setup
1 participant