Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tmdb_lookup release dates #3637

Open
wants to merge 13 commits into
base: develop
Choose a base branch
from

Conversation

lostb1t
Copy link
Contributor

@lostb1t lostb1t commented Dec 16, 2022

Initial WIP of adding release dates to the tmdb lookup plugin.
Few notes:

  • Added timed_lru_cache for lru_cache with cache expiration tho might be better to cache to disk or db to be more memory friendly
  • No estimator in this PR. As it doesn’t make a lot of sense because the est_movie_release is already looking at the primary release date of tmdb. The primary release date includes theatric releases. It would actually be helpfull to be able to define a type of release(s) for estimators.

@lostb1t lostb1t changed the title WIP: DRAFT: tmdb_lookup release dates Dec 16, 2022
@lostb1t lostb1t marked this pull request as draft December 16, 2022 08:52
@lostb1t lostb1t changed the title DRAFT: tmdb_lookup release dates tmdb_lookup release dates Dec 16, 2022
@lostb1t
Copy link
Contributor Author

lostb1t commented Dec 16, 2022

@gazpachoking let me know your thoughts on the bullet points

@lostb1t lostb1t changed the title tmdb_lookup release dates tmdb_lookup release dates and estimator Dec 16, 2022
@lostb1t lostb1t changed the title tmdb_lookup release dates and estimator tmdb_lookup release dates Dec 28, 2022
@lostb1t lostb1t marked this pull request as ready for review December 28, 2022 11:32
@lostb1t
Copy link
Contributor Author

lostb1t commented Jan 3, 2023

@gazpachoking ping

@github-actions
Copy link

github-actions bot commented Jun 2, 2023

This PR is stale because it has been open 150 days with no activity. Remove stale label or comment or this will be closed in 60 days.

@gazpachoking
Copy link
Member

Wow, sorry about my lack of response here. I'm thinking if we add this, we should store it directly in our db, rather than relying on a memory cache.

Copy link

This PR is stale because it has been open 150 days with no activity. Remove stale label or comment or this will be closed in 60 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants