[add] translations filter: Filter by translations #3019

soloam · 2021-05-27T16:58:13Z

Motivation for changes:

Filter entry based on translations (subbed or dubbed) and original language

Detailed changes:

add translations plugin

Config:

        tasks:
            dubbed1:
                mock:
                    - { title: "Attack on Titan S01E01 DUBFrench DUBItalian 720p WEBRip", url: "http://mock.url/file2.torrent" }
                    - { title: "Attack on Titan S01E01 French 720p WEBRip", url: "http://mock.url/file2.torrent" }
                    - { title: "Attack on Titan S01E01 720p WEBRip", url: "http://mock.url/file2.torrent" }
                    - { title: "Attack on Titan S01E01 720p Japanese", url: "http://mock.url/file2.torrent" }


                translations:
                    languages:
                        - "japanese"
                    dubbed:
                        japanese: "accept"
                        default: "reject"

                series:
                    - Attack on Titan:
                        identified_by: ep



            dubbed2:
                mock:
                    - { title: "Show S01E01 Tuga 720p", trakt_series_language:"english", url:"http://mock.url/file2.torrent" }
                    - { title: "Show S01E01 720p",  trakt_series_language:"english", url:"http://mock.url/file2.torrent" }

                translations:
                    languages_synonyms:
                        portuguese:
                            - tuga
                    languages:
                        - "trakt_series_language"
                    dubbed:
                        portuguese: "accept"
                        default: "reject"

                series:
                    - Show:
                        identified_by: ep


            dubbed3:
                mock:
                    - { title: "Movie French 720p", movie_name: "Movie", trakt_language: "english", url:"http://mock.url/file2.torrent" }
                    - { title: "Movie Spanish 720p", movie_name: "Movie",  trakt_language: "english", url:"http://mock.url/file2.torrent" }
                    - { title: "Movie English 720p", movie_name: "Movie",  trakt_language: "english", url:"http://mock.url/file2.torrent" }
                    - { title: "Movie 720p", movie_name: "Movie",  trakt_language: "english", url:"http://mock.url/file2.torrent" }
                    - { title: "Movie En 720p", movie_name: "Movie",  trakt_language: "english", url:"http://mock.url/file2.torrent" }

                translations:
                    languages:
                        - "trakt_language"
                    dubbed: reject

            dubbed_accept:
                mock:
                    - { title: "Movie Dub 720p", movie_name: "Movie", url:"http://mock.url/file2.torrent" }
                    - { title: "Movie Dubbed 720p", movie_name: "Movie", url:"http://mock.url/file2.torrent" }
                    - { title: "Movie 720p", movie_name: "Movie", url:"http://mock.url/file2.torrent" }
                    - { title: "Movie PT_BR 720p", movie_name: "Movie", url:"http://mock.url/file2.torrent" }
                    - { title: "Movie French 720p", movie_name: "Movie", url:"http://mock.url/file2.torrent" }

                translations: accept

            dubbed_reject:
                mock:
                    - { title: "Movie Dub 720p", movie_name: "Movie", url:"http://mock.url/file2.torrent" }
                    - { title: "Movie Dubbed 720p", movie_name: "Movie", url:"http://mock.url/file2.torrent" }
                    - { title: "Movie 720p", movie_name: "Movie", url:"http://mock.url/file2.torrent" }
                    - { title: "Movie PT_BR 720p", movie_name: "Movie", url:"http://mock.url/file2.torrent" }
                    - { title: "Movie French 720p", movie_name: "Movie", url:"http://mock.url/file2.torrent" }

                translations: reject

            subbed1:
                mock:
                    - { title: "Attack on Titan S01E01 SubFrench SubItalian 720p WEBRip", url: "http://mock.url/file2.torrent" }
                    - { title: "Attack on Titan S01E01 SubEnglish 720p WEBRip", url: "http://mock.url/file2.torrent" }
                    - { title: "Attack on Titan S01E01 720p WEBRip", url: "http://mock.url/file2.torrent" }
                    - { title: "Attack on Titan S01E01 720p SubJapanese", url: "http://mock.url/file2.torrent" }
                    - { title: "Attack on Titan S01E01 720p Subbed", url: "http://mock.url/file2.torrent" }


                translations:
                    languages:
                        - "japanese"
                    dubbed: reject
                    subbed:
                        english: "do_nothing"
                        default: "reject"

                series:
                    - Attack on Titan:
                        parse_only: yes
                        identified_by: ep

            subbed2:
                mock:
                    - { title: "Attack on Titan S01E01 SubFrench SubItalian 720p WEBRip", url: "http://mock.url/file2.torrent" }
                    - { title: "Attack on Titan S01E01 SubEnglish 720p WEBRip", url: "http://mock.url/file2.torrent" }
                    - { title: "Attack on Titan S01E01 720p WEBRip", url: "http://mock.url/file2.torrent" }
                    - { title: "Attack on Titan S01E01 720p SubJapanese", url: "http://mock.url/file2.torrent" }
                    - { title: "Attack on Titan S01E01 720p Subbed", url: "http://mock.url/file2.torrent" }


                translations:
                    languages:
                        - "japanese"
                    dubbed: reject
                    subbed: reject

                series:
                    - Attack on Titan:
                        parse_only: yes
                        identified_by: ep

            subbed3:
                mock:
                    - { title: "Attack on Titan S01E01 SubFrench SubItalian 720p", url: "http://mock.url/file2.torrent" }
                    - { title: "Attack on Titan S01E01 SubEnglish 720p WEBRip", url: "http://mock.url/file2.torrent" }
                    - { title: "Attack on Titan S01E01 720p WEBRip", url: "http://mock.url/file2.torrent" }
                    - { title: "Attack on Titan S01E01 720p SubJapanese", url: "http://mock.url/file2.torrent" }
                    - { title: "Attack on Titan S01E01 720p Subbed", url: "http://mock.url/file2.torrent" }


                translations:
                    languages:
                        - "japanese"
                    dubbed: reject
                    subbed: 
                        none: reject
                        default: accept

                series:
                    - Attack on Titan:
                        parse_only: yes
                        identified_by: ep


            do_nothing_test:
                mock:
                    - {'title':'Movie1.720p.PT.ENG.TEST','url':'mock://teste1'}
                    - {'title':'Movie2.720p.Portugues.Ingles.TEST','url':'mock://teste2'}
                    - {'title':'Movie3.1080p.ENG.PT.BluRay.TEST','url':'mock://teste3'}
                translations:
                    languages_synonyms:
                        portuguese:
                            - tuga
                            - portuga
                            - portugues
                        english:
                            - ingles
                            - ing
                        spanish:
                            - espanhol
                        french:
                            - frances
                    dubbed:
                        portuguese: "do_nothing"
                        default: "reject"

Log and/or tests output (preferably both):

Test cases in test_translations_filter.py

To Do:

If merged add to wiki

soloam · 2021-10-13T22:59:27Z

Been using this for some time as a user plugin and works as expected! Is this relevant to flexget? Or can it be closed?

for more information, see https://pre-commit.ci

github-actions · 2022-04-16T02:06:43Z

This PR is stale because it has been open 150 days with no activity. Remove stale label or comment or this will be closed in 60 days.

ghost · 2022-04-18T06:25:18Z

any updates?

github-actions · 2022-09-15T13:25:44Z

This PR is stale because it has been open 150 days with no activity. Remove stale label or comment or this will be closed in 60 days.

paranoidi · 2022-10-09T23:23:45Z

This looks awesome! Sorry for delays.

paranoidi · 2022-10-09T23:25:40Z

flexget/plugins/filter/translations.py

+    def clean_symbols(self, text: str) -> str:
+        """Replaces common symbols with spaces. Also normalize unicode strings in decomposed form.
+
+        Args:


reStructured would be preferable, although not as critical anymore with type hinting

paranoidi · 2022-10-09T23:26:24Z

flexget/plugins/filter/translations.py

+                if mycode:
+                    lang = mycode.name
+            except babelfish.LanguageReverseError:
+                pass


Will hide errors, is this always desirable? Log exception / debug instead?

Now I return a debug message

paranoidi · 2022-10-09T23:28:28Z

flexget/plugins/filter/translations.py

+
+    translations:
+      languages:
+        - "imdb_languages"


I don't quite follow, in some examples the "languages" key contains list of languages like "japanese" but here we have entry field names. If it has some intelligence/magic that allows both, I would much prefer to be explicit and have "language_fields" configuration key instead.

I've split the fields, now we have languages and language_fields

soloam · 2022-10-14T12:44:56Z

Hello @paranoidi I've been out for some time, but now I'm back, I'll look into it and make the adjustments. The change on the language field (and yes it's "magic" to see if it's a language or a field), I don't like that change, but I understand the reason, I'll make the adjustment.

Tks

github-actions · 2023-03-13T12:57:00Z

This PR is stale because it has been open 150 days with no activity. Remove stale label or comment or this will be closed in 60 days.

soloam · 2023-03-13T13:09:54Z

Sorry for the delay on this, had a lot over my hands lately! Going to get back on this ASAP.

for more information, see https://pre-commit.ci

soloam · 2023-05-23T12:18:29Z

I did the reviews sorry for the delay on this @paranoidi I've been very busy.

github-actions · 2023-10-20T12:49:43Z

This PR is stale because it has been open 150 days with no activity. Remove stale label or comment or this will be closed in 60 days.

soloam · 2023-10-20T13:32:45Z

Not yet forgotten! I'll look at this as soon as possible

github-actions · 2024-03-19T01:30:43Z

This PR is stale because it has been open 150 days with no activity. Remove stale label or comment or this will be closed in 60 days.

soloam · 2024-03-21T02:16:01Z

Not forgotten... Just low on time

soloam added 3 commits May 27, 2021 17:54

[add] translations filter: Filter by translations

cd4cde8

[add] translations filter: Specific do_nothing

5ec048c

[add] translations filter: Default actions

5af60cc

soloam and others added 2 commits November 16, 2021 13:45

[add] check translation convertion

aebaebf

[pre-commit.ci] auto fixes from pre-commit.com hooks

f775513

for more information, see https://pre-commit.ci

github-actions bot added the Stale label Apr 16, 2022

github-actions bot removed the Stale label Apr 18, 2022

github-actions bot added the Stale label Sep 15, 2022

paranoidi reviewed Oct 9, 2022

View reviewed changes

paranoidi added Enhancement High Priority and removed Stale labels Oct 9, 2022

github-actions bot added the Stale label Mar 13, 2023

github-actions bot removed the Stale label Mar 14, 2023

soloam and others added 2 commits May 23, 2023 13:17

[add] translations filter: Filter by translations

7ba2a30

[pre-commit.ci] auto fixes from pre-commit.com hooks

272f222

for more information, see https://pre-commit.ci

github-actions bot added the Stale label Oct 20, 2023

github-actions bot removed the Stale label Oct 21, 2023

github-actions bot added the Stale label Mar 19, 2024

github-actions bot removed the Stale label Mar 21, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[add] translations filter: Filter by translations #3019

[add] translations filter: Filter by translations #3019

soloam commented May 27, 2021 •

edited

soloam commented Oct 13, 2021

github-actions bot commented Apr 16, 2022

ghost commented Apr 18, 2022

github-actions bot commented Sep 15, 2022

paranoidi commented Oct 9, 2022

paranoidi Oct 9, 2022

paranoidi Oct 9, 2022

soloam May 23, 2023

paranoidi Oct 9, 2022

soloam May 23, 2023

soloam commented Oct 14, 2022

github-actions bot commented Mar 13, 2023

soloam commented Mar 13, 2023

soloam commented May 23, 2023

github-actions bot commented Oct 20, 2023

soloam commented Oct 20, 2023

github-actions bot commented Mar 19, 2024

soloam commented Mar 21, 2024

[add] translations filter: Filter by translations #3019

Are you sure you want to change the base?

[add] translations filter: Filter by translations #3019

Conversation

soloam commented May 27, 2021 • edited

Motivation for changes:

Detailed changes:

Config:

Log and/or tests output (preferably both):

To Do:

soloam commented Oct 13, 2021

github-actions bot commented Apr 16, 2022

ghost commented Apr 18, 2022

github-actions bot commented Sep 15, 2022

paranoidi commented Oct 9, 2022

paranoidi Oct 9, 2022

Choose a reason for hiding this comment

paranoidi Oct 9, 2022

Choose a reason for hiding this comment

soloam May 23, 2023

Choose a reason for hiding this comment

paranoidi Oct 9, 2022

Choose a reason for hiding this comment

soloam May 23, 2023

Choose a reason for hiding this comment

soloam commented Oct 14, 2022

github-actions bot commented Mar 13, 2023

soloam commented Mar 13, 2023

soloam commented May 23, 2023

github-actions bot commented Oct 20, 2023

soloam commented Oct 20, 2023

github-actions bot commented Mar 19, 2024

soloam commented Mar 21, 2024

soloam commented May 27, 2021 •

edited