875 remove obsolete data classes from db #921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
November 30, 2023 14:30
Signed-off-by: GustaafL <guus@seita.nl>
Signed-off-by: GustaafL <guus@seita.nl>
Signed-off-by: GustaafL <guus@seita.nl>
Signed-off-by: GustaafL <guus@seita.nl>
Signed-off-by: GustaafL <guus@seita.nl>
Flix6x
requested changes
Dec 8, 2023
flexmeasures/data/migrations/versions/ad98460751d9_remove_obsolete_tables.py
Outdated
Show resolved
Hide resolved
flexmeasures/data/migrations/versions/ad98460751d9_remove_obsolete_tables.py
Outdated
Show resolved
Hide resolved
flexmeasures/data/migrations/versions/ad98460751d9_remove_obsolete_tables.py
Outdated
Show resolved
Hide resolved
flexmeasures/data/migrations/versions/ad98460751d9_remove_obsolete_tables.py
Outdated
Show resolved
Hide resolved
added 2 commits
December 13, 2023 14:01
Signed-off-by: GustaafL <guus@seita.nl>
Signed-off-by: GustaafL <guus@seita.nl>
Signed-off-by: GustaafL <guus@seita.nl>
|
Tested with a new database and a database dump. It all worked properly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove obsolete tables from the DB if they are empty, otherwise give the user the choice to continue anyway.
Look & Feel
run
flexmeasures db upgradeHow to test
If all the tables that will be removed are empty there will not be asked for confirmation. To test the check you can add a table name that has data to the table list and run db upgrade.
Further Improvements
Potential improvements to be done in the same PR or follow up Issues/Discussions/PRs.
Related Items
Mention if this PR closes an Issue or Project.