Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add Binary constraint to prevent energy losses (at negative prices) #770

Merged
merged 62 commits into from Aug 3, 2023
Merged

feat: add Binary constraint to prevent energy losses (at negative prices) #770

merged 62 commits into from Aug 3, 2023

Commits on Jul 19, 2023

  1. add highs to requirements 

    Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
    @victorgarcia98
    victorgarcia98 committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    62a3c21 View commit details
    Browse the repository at this point in the history

Commits on Jul 20, 2023

  1. Merge branch 'main' into dependencies/add-highspy

    @victorgarcia98
    victorgarcia98 committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    150a951 View commit details
    Browse the repository at this point in the history

Commits on Jul 21, 2023

  1. Merge branch 'main' into dependencies/add-highspy

    @victorgarcia98
    victorgarcia98 committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    d615b25 View commit details
    Browse the repository at this point in the history

  2. docs: add changelog entry 

    Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
    @victorgarcia98
    victorgarcia98 committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    ebbc65a View commit details
    Browse the repository at this point in the history

Commits on Jul 23, 2023

  1. fix: get results with infeasible termination status instead of Runtim… 

    …eError

Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
    @victorgarcia98
    victorgarcia98 committed Jul 23, 2023
    Configuration menu
    Copy the full SHA
    51a3148 View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2023

  1. feat: add Binary constraint to prevent energy losses, and start new t… 

    …est against negative prices

Signed-off-by: F.N. Claessen <felix@seita.nl>
    @Flix6x
    Flix6x committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    708badf View commit details
    Browse the repository at this point in the history

  2. fx: avoid double solving 

    Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
    @victorgarcia98
    victorgarcia98 committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    a699c16 View commit details
    Browse the repository at this point in the history

  3. style: fix HiGHS capitalization 

    Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
    @victorgarcia98
    victorgarcia98 committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    f6b3772 View commit details
    Browse the repository at this point in the history

  4. remove HiGHS from requirements 

    Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
    @victorgarcia98
    victorgarcia98 committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    6d9c2a6 View commit details
    Browse the repository at this point in the history

  5. remove dependency 

    Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
    @victorgarcia98
    victorgarcia98 committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    58b24e3 View commit details
    Browse the repository at this point in the history

  6. add dependency back 

    Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
    @victorgarcia98
    victorgarcia98 committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    bb00d3a View commit details
    Browse the repository at this point in the history

  7. docs: document how to install HiGHS 

    Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
    @victorgarcia98
    victorgarcia98 committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    d2809ad View commit details
    Browse the repository at this point in the history

  8. add HIghs to Dockerfile 

    Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
    @victorgarcia98
    victorgarcia98 committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    2a94530 View commit details
    Browse the repository at this point in the history

  9. remove extra lines 

    Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
    @victorgarcia98
    victorgarcia98 committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    ffacf30 View commit details
    Browse the repository at this point in the history

  10. fix typos 

    Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
    @victorgarcia98
    victorgarcia98 committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    ce969db View commit details
    Browse the repository at this point in the history

  11. load solution when termination_condition!=infeasible 

    Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
    @victorgarcia98
    victorgarcia98 committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    ae09379 View commit details
    Browse the repository at this point in the history

  12. Merge branch 'main' into dependencies/add-highspy

    @victorgarcia98
    victorgarcia98 committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    c8cb457 View commit details
    Browse the repository at this point in the history

  13. refactor: run data preparation step in a different method 

    Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
    @victorgarcia98
    victorgarcia98 committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    e9d8462 View commit details
    Browse the repository at this point in the history

  14. refactor: create run_device_scheduler function to return model and re… 

    …sults objects and using it in the device_scheduler function

Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
    @victorgarcia98
    victorgarcia98 committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    aa32839 View commit details
    Browse the repository at this point in the history

  15. add asserts and docstring in test_battery_solver_day_3 

    Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
    @victorgarcia98
    victorgarcia98 committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    2a159fb View commit details
    Browse the repository at this point in the history

  16. add documentation for the constraints device_up_derivative_sign and d… 

    …evice_down_derivative_sign

Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
    @victorgarcia98
    victorgarcia98 committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    0d24be6 View commit details
    Browse the repository at this point in the history

  17. install HiGHS in the CI testing env 

    Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
    @victorgarcia98
    victorgarcia98 committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    55a8a4d View commit details
    Browse the repository at this point in the history

  18. address some textual changes 

    Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
    @victorgarcia98
    victorgarcia98 committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    3d249ce View commit details
    Browse the repository at this point in the history

  19. fx CBC capitalization 

    Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
    @victorgarcia98
    victorgarcia98 committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    97d9bde View commit details
    Browse the repository at this point in the history

  20. fix grammar 

    Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
    @victorgarcia98
    victorgarcia98 committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    9a253df View commit details
    Browse the repository at this point in the history

  21. check if there are results in a more robustly 

    Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
    @victorgarcia98
    victorgarcia98 committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    ca7a0e6 View commit details
    Browse the repository at this point in the history

  22. Merge branch 'dependencies/add-highspy' into feature/no-energy-leakage

    @victorgarcia98
    victorgarcia98 committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    7db5e99 View commit details
    Browse the repository at this point in the history

  23. little fixes 

    Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
    @victorgarcia98
    victorgarcia98 committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    aff291e View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2023

  1. improve docstring of _prepare 

    Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
    @victorgarcia98
    victorgarcia98 committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    ce7eafc View commit details
    Browse the repository at this point in the history

Commits on Jul 28, 2023

  1. fix definition of M 

    Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
    @victorgarcia98
    victorgarcia98 committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    d43fbfa View commit details
    Browse the repository at this point in the history

Commits on Jul 31, 2023

  1. improve test 

    Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
    @victorgarcia98
    victorgarcia98 committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    244fd4e View commit details
    Browse the repository at this point in the history

  2. reorder installation instructions for CBC and HiGHS 

    Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
    @victorgarcia98
    victorgarcia98 committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    6c344c5 View commit details
    Browse the repository at this point in the history

  3. add production price fixture 

    Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
    @victorgarcia98
    victorgarcia98 committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    fa96800 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into feature/no-energy-leakage 

    Signed-off-by: Victor <victor@seita.nl>
    @victorgarcia98
    victorgarcia98 committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    af887dc View commit details
    Browse the repository at this point in the history

  5. fix loading results twice 

    Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
    @victorgarcia98
    victorgarcia98 committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    2f5c1c0 View commit details
    Browse the repository at this point in the history

  6. remove TODO 

    Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
    @victorgarcia98
    victorgarcia98 committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    5705de9 View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2023

  1. increment StorageScheduler version 

    Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
    @victorgarcia98
    victorgarcia98 committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    dc44545 View commit details
    Browse the repository at this point in the history

  2. add changelog entry 

    Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
    @victorgarcia98
    victorgarcia98 committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    c0c4800 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into feature/no-energy-leakage

    @victorgarcia98
    victorgarcia98 committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    2b10245 View commit details
    Browse the repository at this point in the history

  4. fix conftest 

    Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
    @victorgarcia98
    victorgarcia98 committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    48fd692 View commit details
    Browse the repository at this point in the history

  5. update test_hashing with a new hash due to the change in the version … 

    …of the StorageScheduler

Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
    @victorgarcia98
    victorgarcia98 committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    b8c546e View commit details
    Browse the repository at this point in the history

  6. feat: in play mode, allow showing any sensor on the asset page (#740) 

    This PR uses the FlexMeasures play mode to allow showing sensors across organisations. When showing simulation results, we want to be able to show results from different scenarios (stored under different accounts) on the same asset page. For example, when comparing a scenario against some other benchmark scenario.


* feat: in play mode, allow showing any sensor on the asset page

Signed-off-by: F.N. Claessen <felix@seita.nl>

* fix checking for config value

Signed-off-by: Nicolas Höning <nicolas@seita.nl>

* more consistent naming of account variable

Signed-off-by: Nicolas Höning <nicolas@seita.nl>

* chore: rename variable of accessible sensors for readability

Signed-off-by: Nicolas Höning <nicolas@seita.nl>

* docs: mention this new possibility in function docstring

Signed-off-by: Nicolas Höning <nicolas@seita.nl>

* fix: do not fail if sensors are not accessible, log a warning for them as well

Signed-off-by: Nicolas Höning <nicolas@seita.nl>

* docs: changelog entry

Signed-off-by: F.N. Claessen <felix@seita.nl>

* docs: changelog warning

Signed-off-by: F.N. Claessen <felix@seita.nl>

---------

Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
Co-authored-by: Nicolas Höning <nicolas@seita.nl>
    @Flix6x @nhoening @victorgarcia98
    2 people authored and victorgarcia98 committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    613039e View commit details
    Browse the repository at this point in the history

  7. fix fixture 

    Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
    @victorgarcia98
    victorgarcia98 committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    c679b66 View commit details
    Browse the repository at this point in the history

  8. Merge branch 'main' into feature/no-energy-leakage

    @victorgarcia98
    victorgarcia98 committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    efd6e9d View commit details
    Browse the repository at this point in the history

  9. Merge branch 'main' into feature/no-energy-leakage 

    Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
    @victorgarcia98
    victorgarcia98 committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    a616ff7 View commit details
    Browse the repository at this point in the history

  10. fix: changelog 

    Signed-off-by: F.N. Claessen <felix@seita.nl>
    @Flix6x
    Flix6x committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    76e29f0 View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2023

  1. revert (the refactoring part of aa32839): prepend model to the return… 

    … tuple of the device_scheduler; this prevents duplicating a large docstring at the cost of introducing a breaking change in the function signature of the device_scheduler (but no external code uses that function to the best of my knowledge) (#781)

Signed-off-by: F.N. Claessen <felix@seita.nl>
    @Flix6x
    Flix6x committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    7a0f929 View commit details
    Browse the repository at this point in the history

  2. clean code and latitude, longitude and account_id to get_or_create_ge… 

    …neric_asset

Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
    @victorgarcia98
    victorgarcia98 committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    5b9f65a View commit details
    Browse the repository at this point in the history

  3. add highspy to test.txt and test.in 

    Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
    @victorgarcia98
    victorgarcia98 committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    8cb58e7 View commit details
    Browse the repository at this point in the history

Commits on Aug 3, 2023

  1. Merge remote-tracking branch 'origin/main' into feature/no-energy-lea… 

    …kage
    @Flix6x
    Flix6x committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    482463f View commit details
    Browse the repository at this point in the history

  2. fix: typos 

    Signed-off-by: F.N. Claessen <felix@seita.nl>
    @Flix6x
    Flix6x committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    8b7f14f View commit details
    Browse the repository at this point in the history

  3. fix: test that needs to get the battery object 

    Signed-off-by: F.N. Claessen <felix@seita.nl>
    @Flix6x
    Flix6x committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    66226ae View commit details
    Browse the repository at this point in the history

  4. fix: typo 

    Signed-off-by: F.N. Claessen <felix@seita.nl>
    @Flix6x
    Flix6x committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    1923fb1 View commit details
    Browse the repository at this point in the history

  5. docs: clarify choice of SoC values in test 

    Signed-off-by: F.N. Claessen <felix@seita.nl>
    @Flix6x
    Flix6x committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    e24bf66 View commit details
    Browse the repository at this point in the history

  6. fix: test case 2 says it tests for no oscillation, which is only guar… 

    …anteed when prefer-charging-sooner is true; otherwise, the solver will be completely indifferent to oscilations during the period with negative prices

Signed-off-by: F.N. Claessen <felix@seita.nl>
    @Flix6x
    Flix6x committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    7f70cb6 View commit details
    Browse the repository at this point in the history

  7. style: streamline variable names in test 

    Signed-off-by: F.N. Claessen <felix@seita.nl>
    @Flix6x
    Flix6x committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    e29575b View commit details
    Browse the repository at this point in the history

  8. revert 48fd692: unnecessary after #695 

    Signed-off-by: F.N. Claessen <felix@seita.nl>
    @Flix6x
    Flix6x committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    90dad65 View commit details
    Browse the repository at this point in the history

  9. style: black 

    Signed-off-by: F.N. Claessen <felix@seita.nl>
    @Flix6x
    Flix6x committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    e7c3d3b View commit details
    Browse the repository at this point in the history

  10. Merge remote-tracking branch 'origin/main' into feature/no-energy-lea… 

    …kage
    @Flix6x
    Flix6x committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    bc4d624 View commit details
    Browse the repository at this point in the history

  11. remove installation of highspy as it's already being installed throug… 

    …h the test requirements.

Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
    @victorgarcia98
    victorgarcia98 committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    c5c4851 View commit details
    Browse the repository at this point in the history

  12. Merge remote-tracking branch 'origin/main' into feature/no-energy-lea… 

    …kage
    @Flix6x
    Flix6x committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    11be24b View commit details
    Browse the repository at this point in the history

  13. fix (docs): comment out cross reference to masked documentation page 

    Signed-off-by: F.N. Claessen <felix@seita.nl>
    @Flix6x
    Flix6x committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    d39dcb1 View commit details
    Browse the repository at this point in the history