Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add device_scheduler page #764

Merged
merged 9 commits into from Jul 21, 2023

Conversation

victorgarcia98
Copy link
Contributor

Description

This PR introduces the LP equations of the device_scheduler function.

Feel free to propose alternative notation.

Look & Feel

image

How to test it

  1. Build documenation
make update-docs
  1. Open the following file in your browser:
<path-to-fm>/flexmeasures/ui/static/documentation/html/concepts/device_scheduler.html

Related Items

#763


  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on code under GPL or other license that is incompatible with FlexMeasures

Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
@victorgarcia98 victorgarcia98 added documentation Improvements or additions to documentation Scheduling labels Jul 19, 2023
@victorgarcia98 victorgarcia98 self-assigned this Jul 19, 2023
Copy link
Contributor

@Flix6x Flix6x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! I pretty much only have some small improvement suggestions.

documentation/concepts/device_scheduler.rst Outdated Show resolved Hide resolved
documentation/concepts/device_scheduler.rst Outdated Show resolved Hide resolved
documentation/concepts/device_scheduler.rst Outdated Show resolved Hide resolved
documentation/concepts/device_scheduler.rst Outdated Show resolved Hide resolved
documentation/concepts/device_scheduler.rst Outdated Show resolved Hide resolved
documentation/concepts/device_scheduler.rst Outdated Show resolved Hide resolved
documentation/concepts/device_scheduler.rst Outdated Show resolved Hide resolved
documentation/concepts/device_scheduler.rst Show resolved Hide resolved
documentation/concepts/device_scheduler.rst Outdated Show resolved Hide resolved
documentation/concepts/device_scheduler.rst Outdated Show resolved Hide resolved
Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
@victorgarcia98
Copy link
Contributor Author

Bedankt!

Copy link
Contributor

@Flix6x Flix6x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 (with me nitpicking)

documentation/concepts/device_scheduler.rst Outdated Show resolved Hide resolved
documentation/concepts/device_scheduler.rst Outdated Show resolved Hide resolved
documentation/concepts/device_scheduler.rst Outdated Show resolved Hide resolved
documentation/concepts/device_scheduler.rst Outdated Show resolved Hide resolved
documentation/concepts/device_scheduler.rst Outdated Show resolved Hide resolved
documentation/concepts/device_scheduler.rst Outdated Show resolved Hide resolved
documentation/concepts/device_scheduler.rst Outdated Show resolved Hide resolved
documentation/concepts/device_scheduler.rst Outdated Show resolved Hide resolved
Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
@victorgarcia98
Copy link
Contributor Author

Thanks for the review @Flix6x!

Do we need a changelog entry for this PR?

@Flix6x
Copy link
Contributor

Flix6x commented Jul 21, 2023

Yes, I'd like that.

Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
@victorgarcia98 victorgarcia98 merged commit 3f83cf3 into main Jul 21, 2023
4 checks passed
@victorgarcia98 victorgarcia98 deleted the docs/scheduling/linear_programming branch July 21, 2023 12:01
@Flix6x Flix6x added this to the 0.15.0 milestone Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation Scheduling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants