feat: let CLI users pass a JSON list (as a string) to set an asset or sensor attribute #762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… sensor attribute Signed-off-by: Nicolas Höning <nicolas@seita.nl>
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
Ahmad-Wahid
reviewed
Jul 18, 2023
Ahmad-Wahid
approved these changes
Jul 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We have the
flexmeasures edit attributeCLI command.It allows to edit attribute values of several types on assets and sensors: float, bool, str, int.
We are handling lists as attribute values, as well (e.g. generic_asset.sensors_to_show), and are thinking about dictionaries.
This PR is about supporting these two types in the CLI command, as well.
Look & Feel
flexmeasures edit attribute --asset-id 27 --attribute "sensors_to_show" --list '[14, 54, 55,56]'
How to test
Edit an attribute and check in the CLI or SQL if the attribute has changed:
Also pass in wrong (non parseable) values
Further Improvements
Still need to support dicts, but that could happen in the same way easily.