Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sensors): adds fetch_one sensor endpoint to API #759

Merged
merged 6 commits into from Jul 21, 2023
Merged

Conversation

GustaafL
Copy link
Contributor

@GustaafL GustaafL commented Jul 5, 2023

Description

Adds an endpoint to fetch one sensor.

Look & Feel

Endpoint for a single sensor is: <host>/api/v3_0/sensors/<id>

Further Improvements

Working on more endpoints for the sensor. #433

Related Items

#433


  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on code under GPL or other license that is incompatible with FlexMeasures

Signed-off-by: GustaafL <guus@seita.nl>
@GustaafL GustaafL requested a review from nhoening July 5, 2023 13:57
Copy link
Contributor

@nhoening nhoening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe I found one problem that needs fixing.
Looks good otherwise!

flexmeasures/api/v3_0/sensors.py Outdated Show resolved Hide resolved
flexmeasures/api/v3_0/tests/test_sensors_api.py Outdated Show resolved Hide resolved
@nhoening nhoening added this to the 0.15.0 milestone Jul 18, 2023
Signed-off-by: GustaafL <guus@seita.nl>
@GustaafL GustaafL requested a review from nhoening July 19, 2023 08:31
@nhoening
Copy link
Contributor

@GustaafL Can you add a changelog entry for the sensor CRUD endpoint(s)? That entry can hopefully mention your next PR as well (in 0.15), but let's get it started now.

Signed-off-by: GustaafL <guus@seita.nl>
documentation/api/change_log.rst Outdated Show resolved Hide resolved
Signed-off-by: GustaafL <guus@seita.nl>
@GustaafL GustaafL requested a review from nhoening July 20, 2023 15:57
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
@nhoening nhoening merged commit e0fd2d9 into main Jul 21, 2023
3 of 4 checks passed
@nhoening nhoening deleted the 433-fetch-one branch July 21, 2023 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants