Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: relax constraint for overlaying plot traces for sensors with various resolutions #743

Merged
merged 2 commits into from Jun 23, 2023

Conversation

Flix6x
Copy link
Contributor

@Flix6x Flix6x commented Jun 21, 2023

This PR makes it possible to show e.g. two price sensors in one chart, where one of them records hourly prices and the other records quarterhourly prices.

Follow-up:

  • The assertion error is just a server error now, but should be communicated back to the user in the UI.

…ious resolutions

Signed-off-by: F.N. Claessen <felix@seita.nl>
Copy link
Contributor

@victorgarcia98 victorgarcia98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x Flix6x added this to the 0.14.1 milestone Jun 23, 2023
@Flix6x Flix6x merged commit caabe68 into main Jun 23, 2023
6 of 7 checks passed
@Flix6x Flix6x deleted the fix/overlay-multi-resolution-sensor-charts branch June 23, 2023 10:15
Flix6x added a commit that referenced this pull request Jun 26, 2023
…r sensors with various resolutions (#743)

This PR makes it possible to show e.g. two price sensors in one chart, where one of them records hourly prices and the other records quarterhourly prices.

* fix: relax constraint for overlaying plot traces for sensors with various resolutions

Signed-off-by: F.N. Claessen <felix@seita.nl>

* docs: changelog entry

Signed-off-by: F.N. Claessen <felix@seita.nl>

---------

Signed-off-by: F.N. Claessen <felix@seita.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants