feat: sensors with % units get chart including 0-100% in their domain #739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: F.N. Claessen <felix@seita.nl>
There was a problem hiding this comment.
Nice!
It's good that you did union to support other valid percentages (e.g. negative or >100%).
Trying it out locally I find that the it doesn't show the whole range [0,100], just [0, max(data)]. Optionally, I would use the interval [0,105], to leave some space above.
When 100% is in the data:
When 100% not in the data:
|
Looks like you tried the sensor page. Which is good that you did. I had only implemented this for the asset page. I'll amend. |
Signed-off-by: F.N. Claessen <felix@seita.nl>
…n-for-percentage-sensors
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having percentages within [0, 100] is such a common use case that we should always include this domain in the scale. This makes it easier to read off individual charts, and also to compare across charts (for example, when showing simulation results of different scenarios).