Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: drop NaN values when saving the report to the database #735

Merged
merged 5 commits into from Jun 20, 2023
Merged

fix: drop NaN values when saving the report to the database #735

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ccbb4be
fix: drop NaN values when saving the report to the database
Flix6x Jun 19, 2023
f3c783c
docs: changelog entry
Flix6x Jun 19, 2023
ba06574
docs: explain abbreviation
Flix6x Jun 19, 2023
9c49d60
docs: CLI changelog entry
Flix6x Jun 19, 2023
9048270
Merge remote-tracking branch 'origin/main' into bug/drop-nan-report-v…
Flix6x Jun 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions documentation/changelog.rst
View file
Open in desktop
Expand Up @@ -25,6 +25,7 @@ Bugfixes
-----------

* Relax constraint validation of `StorageScheduler` to accommodate violations caused by floating point precision [see `PR #731 <https://www.github.com/FlexMeasures/flexmeasures/pull/731>`_]
* Avoid saving any :abbr:`NaN (not a number)` values to the database, when calling ``flexmeasures add report`` [see `PR #735 <https://www.github.com/FlexMeasures/flexmeasures/pull/735>`_]
* Fix browser console error when loading asset or sensor page with only a single data point [see `PR #732 <https://www.github.com/FlexMeasures/flexmeasures/pull/732>`_]


Expand Down
5 changes: 5 additions & 0 deletions documentation/cli/change_log.rst
View file
Open in desktop
Expand Up @@ -9,6 +9,11 @@ since v0.15.0 | July XX, 2023

* Allow deleting multiple sensors with a single call to ``flexmeasures delete sensor`` by passing the ``--id`` option multiple times.

since v0.14.1 | June XX, 2023
=================================

* Avoid saving any :abbr:`NaN (not a number)` values to the database, when calling ``flexmeasures add report``.

since v0.14.0 | June 15, 2023
=================================

Expand Down
4 changes: 2 additions & 2 deletions flexmeasures/cli/data_add.py
View file
Open in desktop
Expand Up @@ -1347,10 +1347,10 @@ def add_report( # noqa: C901
"Report computation done, but the report is empty.", **MsgStyle.WARN
)

# save the report it's not running in dry mode
# save the report if it's not running in dry mode
if not dry_run:
click.echo("Saving report to the database...")
save_to_db(result)
save_to_db(result.dropna())
db.session.commit()
click.secho(
"Success. The report has been saved to the database.",
Expand Down