Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: show split data during fall DST transition in daily heatmap #723

Merged
merged 41 commits into from Aug 3, 2023

Conversation

Flix6x
Copy link
Contributor

@Flix6x Flix6x commented Jun 13, 2023

This PR masks overlapping data during a DST transition (commonly on 1 day during fall) and then shows it split up vertically in a separate layer.

A small horizontal white bar (with height probably equal to 1/25th of the row height) is still visible, but it's a bit of a pain to get rid of.

visualization (5)

Flix6x added 12 commits June 6, 2023 22:17
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x Flix6x added the UI label Jun 13, 2023
@Flix6x Flix6x self-assigned this Jun 13, 2023
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
Copy link
Contributor Author

Flix6x commented Jun 13, 2023

Update without the white bar:

visualization (6)

Copy link
Contributor

@victorgarcia98 victorgarcia98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

The only thing is that somehow we should indicate which block (top and bottom) belongs to what timezone (UTC+1 or UTC+2, in general, $timezone \pm 1$ ).

Aside, maybe we should also warn that the user is visualizing a period that contains a change of hour.

…sition

Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
@victorgarcia98
Copy link
Contributor

It looks great!

Some comments and test that I run:

  • The chart looks a bit broken when there's no data in the selected period:

image

  • The message Please note that the sensor data you are viewing includes a daylight saving time (DST) transition. appears in both types of charts. I like this though as it reminds you that you could see some "artifacts".

  • Both messages look good, maybe the space it too big. Also, I would prefer to see the offset in hours, although it's good like it is.

image

@victorgarcia98 victorgarcia98 self-requested a review July 31, 2023 18:02
@Flix6x Flix6x changed the title feat: show split data during fall DST transition in sensor matrix chart feat: show split data during fall DST transition in daily heatmap Aug 1, 2023
Flix6x and others added 5 commits August 1, 2023 13:10
Signed-off-by: F.N. Claessen <felix@seita.nl>
…same number of data points, arbitrarily pick the first one in the data

Signed-off-by: F.N. Claessen <felix@seita.nl>
…s sources (#780)

Signed-off-by: F.N. Claessen <felix@seita.nl>
Base automatically changed from sensor-matrix-chart to main August 3, 2023 08:28
@Flix6x Flix6x added this to the 0.15.0 milestone Aug 3, 2023
@Flix6x Flix6x merged commit 48aaef7 into main Aug 3, 2023
4 checks passed
@Flix6x Flix6x deleted the sensor-matrix-chart-fall-dst-transition branch August 3, 2023 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants