New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Blocked Loading Mixed Active Content Issue Prevents Chart Viewing on Flexmeasures App #716
Conversation
Signed-off-by: Ahmad-Wahid <59763365+Ahmad-Wahid@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
I just thought that this should get an entry in the changelog. Now I am a bit stumped describing the problem. |
Could we access to that PythonAnyWhere hosted app from external internet? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deserves a changelog entry in my opinion as well.
I sometimes use ngrok http 5000
to test how UI features I'm developing would feel on a touchscreen device. It basically forwards my http localhost to a https web url, which leads to the same mixed content issue. I just verified this PR solves that for me, too. Which is great! Although I had to comment out the check for the development
flask env. Why aren't we allowing this in development, too?
I do believe this is likely to happen in other production scenarios, but why is PA different? Would be good to understand. We can look at the network tab on the production system and check what URL is called for this API endpoint by the asset page there... |
…ue-prevents-chart-viewing-on-flexmeasures-app
…ue-prevents-chart-viewing-on-flexmeasures-app
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
…-chart-viewing-on-flexmeasures-app' of github.com:FlexMeasures/flexmeasures into 714-blocked-loading-mixed-active-content-issue-prevents-chart-viewing-on-flexmeasures-app
This update addresses the problem that was preventing the viewing of charts on the Flexmeasures app. By modifying the base.html file, we now perform a check for the flask env variable. If the environment is set to
production
, the app will utilize theHTTPS
protocol; otherwise, it will useHTTP
. This adjustment ensures that the loading of mixed active content is unblocked, enabling smooth chart viewing on the app.