Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create command to show available Schedulers #708

Merged
merged 6 commits into from Jun 9, 2023

Conversation

Ahmad-Wahid
Copy link
Contributor

This PR builds upon the previous work done in PR #686, which introduced the command flexmeasures show reporters. Now, we extend this functionality to include the Scheduler class as well. The new command, flexmeasures show schedulers, allows users to view a comprehensive list of all available schedulers within flexmeasures.

Signed-off-by: Ahmad-Wahid <59763365+Ahmad-Wahid@users.noreply.github.com>
@Ahmad-Wahid Ahmad-Wahid added enhancement New feature or request Scheduling CLI labels May 31, 2023
@Ahmad-Wahid Ahmad-Wahid self-assigned this May 31, 2023
@Ahmad-Wahid Ahmad-Wahid linked an issue May 31, 2023 that may be closed by this pull request
Signed-off-by: Ahmad-Wahid <59763365+Ahmad-Wahid@users.noreply.github.com>
Copy link
Contributor

@Flix6x Flix6x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's refactor to prevent more or less duplicate code.

I think the common term we use for schedulers, forecasters and reporters is data generators, so the util function could use that term.

flexmeasures/app.py Outdated Show resolved Hide resolved
Signed-off-by: Ahmad-Wahid <59763365+Ahmad-Wahid@users.noreply.github.com>
@Ahmad-Wahid
Copy link
Contributor Author

Ahmad-Wahid commented Jun 5, 2023

I have created a generic function list_items which is called by the following commands.

Executing flexmeasures show schedulers would display the relevant information.

name                version  author    module
----------------  ---------  --------  -----------------------------------------
StorageScheduler          1  Seita     flexmeasures.data.models.planning.storage

and flexmeasures show reporters would show

name              version  author    module
--------------  ---------  --------  --------------------------------------------------
PandasReporter          1            flexmeasures.data.models.reporting.pandas_reporter

@Ahmad-Wahid Ahmad-Wahid requested a review from Flix6x June 5, 2023 19:17
Flix6x and others added 3 commits June 6, 2023 09:07
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
Copy link
Contributor

@Flix6x Flix6x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work refactoring, @Ahmad-Wahid!

@Flix6x Flix6x added this to the 0.14.0 milestone Jun 6, 2023
@Flix6x Flix6x merged commit 726cd32 into main Jun 9, 2023
7 checks passed
@Flix6x Flix6x deleted the 689-create-command-to-show-available-schedulers branch June 9, 2023 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLI enhancement New feature or request Scheduling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create command to show available Schedulers
3 participants