Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(scheduling): Add multiple maxima and minima constraints into StorageScheduler #680

Merged
merged 19 commits into from May 29, 2023
Merged

feat(scheduling): Add multiple maxima and minima constraints into StorageScheduler #680

merged 19 commits into from May 29, 2023

Commits on May 11, 2023

  1. fix: deprecated decorator wasn't returning the value of the moved cal… 

    …lable.

Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
    @victorgarcia98
    victorgarcia98 committed May 11, 2023
    Copy the full SHA
    43cf12e View commit details
    Browse the repository at this point in the history

  2. fix: update test to check that the decorator is returning 

    Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
    @victorgarcia98
    victorgarcia98 committed May 11, 2023
    Copy the full SHA
    583bd28 View commit details
    Browse the repository at this point in the history

  3. feat: add SOCValueSchema 

    Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
    @victorgarcia98
    victorgarcia98 committed May 11, 2023
    Copy the full SHA
    3e0744c View commit details
    Browse the repository at this point in the history

  4. feat: pass soc_maxima and soc_minima to device_scheduler 

    style: rename build_device_soc_targets to build_device_soc_values

Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
    @victorgarcia98
    victorgarcia98 committed May 11, 2023
    Copy the full SHA
    e88fa69 View commit details
    Browse the repository at this point in the history

  5. feat: add test test_soc_bounds_timeseries 

    Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
    @victorgarcia98
    victorgarcia98 committed May 11, 2023
    Copy the full SHA
    633142d View commit details
    Browse the repository at this point in the history

Commits on May 17, 2023

  1. test: check for inequality rather than equality constraints 

    Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
    @victorgarcia98
    victorgarcia98 committed May 17, 2023
    Copy the full SHA
    10de976 View commit details
    Browse the repository at this point in the history

Commits on May 18, 2023

  1. Merge branch 'main' into max_min_soc_timeseries

    @victorgarcia98
    victorgarcia98 committed May 18, 2023
    Copy the full SHA
    db317f7 View commit details
    Browse the repository at this point in the history

  2. fix: correcting sunset version 

    Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
    @victorgarcia98
    victorgarcia98 committed May 18, 2023
    Copy the full SHA
    ec60079 View commit details
    Browse the repository at this point in the history

  3. refactor: use new function 

    Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
    @victorgarcia98
    victorgarcia98 committed May 18, 2023
    Copy the full SHA
    121231a View commit details
    Browse the repository at this point in the history

  4. refactor: finishing refactor (I forgot two calls). 

    Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
    @victorgarcia98
    victorgarcia98 committed May 18, 2023
    Copy the full SHA
    a548145 View commit details
    Browse the repository at this point in the history

Commits on May 23, 2023

  1. docs: update the endpoint trigger_schedule with an example on how to … 

    …use soc_minima

Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
    @victorgarcia98
    victorgarcia98 committed May 23, 2023
    Copy the full SHA
    ac70366 View commit details
    Browse the repository at this point in the history

  2. feat: add constraint validation 

    Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
    @victorgarcia98
    victorgarcia98 committed May 23, 2023
    Copy the full SHA
    0211978 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into max_min_soc_timeseries

    @victorgarcia98
    victorgarcia98 committed May 23, 2023
    Copy the full SHA
    3f4df10 View commit details
    Browse the repository at this point in the history

  4. docs: add chagelog entry 

    Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
    @victorgarcia98
    victorgarcia98 committed May 23, 2023
    Copy the full SHA
    eb6f9b7 View commit details
    Browse the repository at this point in the history

Commits on May 25, 2023

  1. Review fixes max min soc timeseries (#700) 

    * style: sphinx docstrings

Signed-off-by: F.N. Claessen <felix@seita.nl>

* style: more detailed type annotation

Signed-off-by: F.N. Claessen <felix@seita.nl>

* style: consistency

Signed-off-by: F.N. Claessen <felix@seita.nl>

* fix: incomplete type annotation

Signed-off-by: F.N. Claessen <felix@seita.nl>

* fix: validation A.1)

Signed-off-by: F.N. Claessen <felix@seita.nl>

* fix: Validation B.2)

Signed-off-by: F.N. Claessen <felix@seita.nl>

* fix: Validation C.1)

Signed-off-by: F.N. Claessen <felix@seita.nl>

* fix: Validation C.3)

Signed-off-by: F.N. Claessen <felix@seita.nl>

* fix: Validation C.4)

Signed-off-by: F.N. Claessen <felix@seita.nl>

* refactor: move statements to where they matter

Signed-off-by: F.N. Claessen <felix@seita.nl>

* style: consistency (also: https://books.google.com/ngrams/graph?content=infeasible%2Cunfeasible&year_start=1800&year_end=2019&corpus=en-2019&smoothing=0&case_insensitive=true )

Signed-off-by: F.N. Claessen <felix@seita.nl>

* style: Validation B.2)

Signed-off-by: F.N. Claessen <felix@seita.nl>

---------

Signed-off-by: F.N. Claessen <felix@seita.nl>
    @Flix6x
    Flix6x committed May 25, 2023
    Copy the full SHA
    fb36f49 View commit details
    Browse the repository at this point in the history

Commits on May 26, 2023

  1. refactor: Constraint validation for cases A and B (#702) 

    * style: sphinx docstrings

Signed-off-by: F.N. Claessen <felix@seita.nl>

* style: more detailed type annotation

Signed-off-by: F.N. Claessen <felix@seita.nl>

* style: consistency

Signed-off-by: F.N. Claessen <felix@seita.nl>

* fix: incomplete type annotation

Signed-off-by: F.N. Claessen <felix@seita.nl>

* fix: validation A.1)

Signed-off-by: F.N. Claessen <felix@seita.nl>

* fix: Validation B.2)

Signed-off-by: F.N. Claessen <felix@seita.nl>

* fix: Validation C.1)

Signed-off-by: F.N. Claessen <felix@seita.nl>

* fix: Validation C.3)

Signed-off-by: F.N. Claessen <felix@seita.nl>

* fix: Validation C.4)

Signed-off-by: F.N. Claessen <felix@seita.nl>

* refactor: move statements to where they matter

Signed-off-by: F.N. Claessen <felix@seita.nl>

* style: consistency (also: https://books.google.com/ngrams/graph?content=infeasible%2Cunfeasible&year_start=1800&year_end=2019&corpus=en-2019&smoothing=0&case_insensitive=true )

Signed-off-by: F.N. Claessen <felix@seita.nl>

* style: Validation B.2)

Signed-off-by: F.N. Claessen <felix@seita.nl>

* refactor: Constraint validation for cases A and B

Signed-off-by: F.N. Claessen <felix@seita.nl>

* style: fixing typos

Signed-off-by: Victor Garcia Reolid <victor@seita.nl>

* fix: add comments clarifying why we need to sort the `{equals, max, min}_extended` series

Signed-off-by: Victor Garcia Reolid <victor@seita.nl>

* refactor:  create storage_device_constraints inside of add_storage_constraints

Signed-off-by: Victor Garcia Reolid <victor@seita.nl>

* reactor: max_soc -> soc_max

Signed-off-by: Victor Garcia Reolid <victor@seita.nl>

* reactor: min_soc -> soc_min

Signed-off-by: Victor Garcia Reolid <victor@seita.nl>

* feat: update validate_constraint to accept arbitrary constraint expressions

Signed-off-by: Victor Garcia Reolid <victor@seita.nl>

* style: fixing some refactor that affected the comments

Signed-off-by: Victor Garcia Reolid <victor@seita.nl>

---------

Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
Co-authored-by: Victor Garcia Reolid <victor@seita.nl>
    @Flix6x @victorgarcia98
    Flix6x and victorgarcia98 committed May 26, 2023
    Copy the full SHA
    9aed98f View commit details
    Browse the repository at this point in the history

Commits on May 29, 2023

  1. style: remove left-over print 

    Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
    @victorgarcia98
    victorgarcia98 committed May 29, 2023
    Copy the full SHA
    70cbb3e View commit details
    Browse the repository at this point in the history

  2. fix: escape backslash in regex 

    Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
    @victorgarcia98
    victorgarcia98 committed May 29, 2023
    Copy the full SHA
    e3807ed View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into max_min_soc_timeseries 

    Signed-off-by: Victor <victor@seita.nl>
    @victorgarcia98
    victorgarcia98 committed May 29, 2023
    Copy the full SHA
    f2ee39e View commit details
    Browse the repository at this point in the history