Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(scheduling): Storage scheduler supports losses over time #679

Merged
merged 27 commits into from Jun 12, 2023

Conversation

Flix6x
Copy link
Contributor

@Flix6x Flix6x commented May 11, 2023

Closes #639.

Potential follow-up: support setting a storage efficiency in units of %/<any time unit>, and let the server convert to units of %/<sensor resolution>. Note that this is a compound interest calculation, which is not supported by pint. *

* For example, a storage efficiency of 99 percent per (absolute) day, for scheduling a 1-hour resolution sensor, should be passed to the scheduler as a storage efficiency of $0.99^{1/24}$.

To do:

Flix6x added 8 commits May 9, 2023 16:59
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
…itions

Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x Flix6x added this to the 0.14.0 milestone May 11, 2023
@Flix6x Flix6x self-assigned this May 11, 2023
@Flix6x Flix6x linked an issue May 11, 2023 that may be closed by this pull request
4 tasks
@Flix6x Flix6x marked this pull request as ready for review May 11, 2023 12:40
@Flix6x Flix6x requested a review from nhoening May 11, 2023 12:40
@Flix6x Flix6x added this to In progress in More powerful scheduling of sensors via automation May 11, 2023
Copy link
Contributor

@nhoening nhoening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice PR.
Mostly I have understanding questions, I don't think I caught a problem.

flexmeasures/cli/data_add.py Show resolved Hide resolved
flexmeasures/utils/calculations.py Show resolved Hide resolved
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
…er-time

# Conflicts:
#	flexmeasures/data/models/planning/storage.py
#	flexmeasures/data/models/planning/tests/test_solver.py
#	flexmeasures/data/schemas/scheduling/storage.py
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x Flix6x requested a review from nhoening June 6, 2023 12:15
Copy link
Contributor

@nhoening nhoening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work - minor comments on two things only.

More powerful scheduling of sensors automation moved this from In progress to Reviewer approved Jun 11, 2023
@nhoening
Copy link
Contributor

Let's create a follow-up issue for your idea of storage efficiency in units of %/ - I believe that will definitely make this easier to use.

@nhoening
Copy link
Contributor

Let's create a follow-up issue for your idea of storage efficiency in units of %/ - I believe that will definitely make this easier to use.

I created #720

Flix6x added 12 commits June 12, 2023 20:13
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
…ma fields

Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
…er-time

# Conflicts:
#	documentation/changelog.rst
Signed-off-by: F.N. Claessen <felix@seita.nl>
…ports` and `flexmeasures show schedulers` CLI commands

Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x Flix6x merged commit 6b0e04b into main Jun 12, 2023
7 checks passed
More powerful scheduling of sensors automation moved this from Reviewer approved to Done Jun 12, 2023
@Flix6x Flix6x deleted the 639-storage-losses-over-time branch June 12, 2023 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Storage losses over time
2 participants