Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support Pandas 2 #673

Merged
merged 18 commits into from Jun 13, 2023
Merged

feat: Support Pandas 2 #673

merged 18 commits into from Jun 13, 2023

Conversation

Flix6x
Copy link
Contributor

@Flix6x Flix6x commented May 8, 2023

Flix6x added 8 commits May 5, 2023 20:21
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x Flix6x added this to the 0.14.0 milestone May 8, 2023
@Flix6x Flix6x self-assigned this May 8, 2023
Base automatically changed from remove-api-1-to-2 to main May 8, 2023 13:15
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x Flix6x marked this pull request as ready for review June 13, 2023 09:33
@Flix6x Flix6x requested a review from nhoening June 13, 2023 09:34
Copy link
Contributor

@nhoening nhoening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So we still pin to 1.5.3 right? (requirements/app.txt says: pandas==1.5.3`)

  • Have you run the tests with pandas 2.0 installed? (I'd be interested in the difference in timing btw :)
  • Why not move up the pin now? It's by now mostly for developers and the Docker image. If you opt to wait, it means you want to gather experience?

@Flix6x
Copy link
Contributor Author

Flix6x commented Jun 13, 2023

Why not move up the pin now?

I want to, but I'm struggling to do this successfully with any of our make commands. Can you take a look? I shouldn't manually change the requirements/app.txt, right?

# Conflicts:
#	documentation/changelog.rst
@nhoening
Copy link
Contributor

Yes, that would update many others, as well. Best to update all new pins right after the next release.

But maybe you can pip-install pandas 2, to see if our tests pass (and are faster)

Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
Copy link
Contributor Author

Flix6x commented Jun 13, 2023

Thanks. The results:

  • 208.13s on Pandas 1.5.3
  • 202.47s on Pandas 2.0.2

I did notice a small fix was needed with some of the new reporter functionality. So I pushed one more commit.

Signed-off-by: F.N. Claessen <felix@seita.nl>
@nhoening
Copy link
Contributor

* 208.13s on Pandas 1.5.3
* 202.47s on Pandas 2.0.2

Ah, no big speed gain here :)
But we have very little test data, of course.

@Flix6x Flix6x merged commit d4178d6 into main Jun 13, 2023
5 of 7 checks passed
@Flix6x Flix6x deleted the support-pandas-2 branch June 13, 2023 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants