Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GET /api/v3_0/assets/public should ask for token authentication #649

Merged
merged 2 commits into from Apr 26, 2023
Merged

GET /api/v3_0/assets/public should ask for token authentication #649

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
35b0056
GET /assets/public should ask for token authentication, as it's meant…
nhoening Apr 25, 2023
ea8d989
add changelog entry
nhoening Apr 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions flexmeasures/api/v3_0/assets.py
View file
Open in desktop
Expand Up @@ -2,7 +2,7 @@

from flask import current_app
from flask_classful import FlaskView, route
from flask_security import login_required
from flask_security import auth_token_required
from flask_json import as_json
from marshmallow import fields
from webargs.flaskparser import use_kwargs, use_args
Expand Down Expand Up @@ -81,7 +81,7 @@ def index(self, account: Account):
return assets_schema.dump(account.generic_assets), 200

@route("/public", methods=["GET"])
@login_required
@auth_token_required
@as_json
def public(self):
"""Return all public assets.
Expand Down
9 changes: 9 additions & 0 deletions flexmeasures/api/v3_0/tests/test_assets_api.py
View file
Open in desktop
Expand Up @@ -102,13 +102,22 @@ def test_get_assets(
assert turbine["account_id"] == setup_accounts["Supplier"].id


def test_get_public_assets_noauth(client, setup_api_test_data, setup_accounts):
get_assets_response = client.get(
url_for("AssetAPI:public"), headers={"content-type": "application/json"}
)
print("Server responded with:\n%s" % get_assets_response.json)
assert get_assets_response.status_code == 401


def test_get_public_assets(client, setup_api_test_data, setup_accounts):
auth_token = get_auth_token(client, "test_admin_user@seita.nl", "testtest")
get_assets_response = client.get(
url_for("AssetAPI:public"),
headers={"content-type": "application/json", "Authorization": auth_token},
)
print("Server responded with:\n%s" % get_assets_response.json)
assert get_assets_response.status_code == 200
assert len(get_assets_response.json) == 1
assert get_assets_response.json[0]["name"] == "troposphere"

Expand Down