Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

559 enhance replay feature with ruler showing current time #560

Merged
merged 5 commits into from Dec 20, 2022
Merged

559 enhance replay feature with ruler showing current time #560

merged 5 commits into from Dec 20, 2022

Conversation

Flix6x
Copy link
Contributor

@Flix6x Flix6x commented Dec 20, 2022

No description provided.

@Flix6x
Add layer with replay ruler
4bbb781 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
Also add replay ruler to sensor bar chart
9a72c56 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
Refactor function to static dict
141dc6d 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
Finalize once each replay step
14955a3 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x Flix6x self-assigned this Dec 20, 2022
@Flix6x Flix6x linked an issue Dec 20, 2022 that may be closed by this pull request
Enhance replay feature with ruler showing current time #559
Closed
@coveralls
Copy link
Collaborator

coveralls commented Dec 20, 2022 •
edited

Pull Request Test Coverage Report for Build 3741635133

  • 2 of 2 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.003%) to 65.04%
Totals Coverage Status
Change from base Build 3734732573: 0.003%
Covered Lines: 6690
Relevant Lines: 9643
💛 - Coveralls

@Flix6x
Changelog entry
e287622 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x Flix6x marked this pull request as ready for review December 20, 2022 15:01
@Flix6x Flix6x requested a review from nhoening December 20, 2022 15:01
@Flix6x Flix6x added this to the 0.12.0 milestone Dec 20, 2022
@Flix6x Flix6x merged commit 4dcec47 into main Dec 20, 2022
@Flix6x Flix6x deleted the 559-enhance-replay-feature-with-ruler-showing-current-time branch December 20, 2022 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nhoening nhoening nhoening approved these changes

Assignees

@Flix6x Flix6x

Labels
UI
Projects
None yet
Milestone
0.12.0
Development

Successfully merging this pull request may close these issues.

Enhance replay feature with ruler showing current time
3 participants
@Flix6x @coveralls @nhoening