Fix bugs in tutorial and CLI scheduling trigger #545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
…. no job) Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Flix6x
added
bug
8 tasks
|
Actually, in my current refactoring PR, I go the same route, for the reason you mention. Maybe it's a bit cleaner there. I worry that this PR and #537 will have quite some merge conflicts ... |
|
But at least this one is small. |
nhoening
approved these changes
Dec 1, 2022
Pull Request Test Coverage Report for Build 3595654316
💛 - Coveralls |
Signed-off-by: F.N. Claessen <felix@seita.nl>
|
Doesn't need a changelog entry imo, because the bugs aren't part of any release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd like your opinion on the extra call to
ensure_storage_specsinmake_schedule. If you go through the job route (withcreate_scheduling_job), it now gets called twice: once before creating the job (which makes sense to me, because you want to let the user know of any problems straight away), and another time when executing the job. Is that okay?