Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug in flexmeasures show beliefs in case of empty sensors #539

Merged
merged 3 commits into from Nov 25, 2022
Merged

Bug in flexmeasures show beliefs in case of empty sensors #539

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0784476
Do not remove items from list while iterating over that same list
Flix6x Nov 24, 2022
9f02317
Merge remote-tracking branch 'origin/main' into bug-show-beliefs-incl…
Flix6x Nov 25, 2022
a612327
Changelog entry
Flix6x Nov 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion documentation/changelog.rst
View file
Open in desktop
Expand Up @@ -19,7 +19,7 @@ New features

Bugfixes
-----------
* The CLI command ``flexmeasures show beliefs`` now supports plotting time series data that includes NaN values, and provides better support for plotting multiple sensors that do not share the same unit [see `PR #516 <http://www.github.com/FlexMeasures/flexmeasures/pull/516>`_]
* The CLI command ``flexmeasures show beliefs`` now supports plotting time series data that includes NaN values, and provides better support for plotting multiple sensors that do not share the same unit [see `PR #516 <http://www.github.com/FlexMeasures/flexmeasures/pull/516>`_ and `PR #539 <http://www.github.com/FlexMeasures/flexmeasures/pull/539>`_]
* Consistent CLI/UI support for asset lat/lng positions up to 7 decimal places (previously the UI rounded to 4 decimal places, whereas the CLI allowed more than 4) [see `PR #522 <http://www.github.com/FlexMeasures/flexmeasures/pull/522>`_]

Infrastructure / Support
Expand Down
5 changes: 4 additions & 1 deletion flexmeasures/cli/data_show.py
View file
Open in desktop
Expand Up @@ -310,11 +310,14 @@ def plot_beliefs(
sum_multiple=False,
)
# only keep non-empty
empty_sensors = []
for s in sensors:
if beliefs_by_sensor[s.name].empty:
click.echo(f"No data found for sensor '{s.name}' (ID: {s.id})")
beliefs_by_sensor.pop(s.name)
sensors.remove(s)
empty_sensors.append(s)
for s in empty_sensors:
sensors.remove(s)
if len(beliefs_by_sensor.keys()) == 0:
click.echo("No data found!")
raise click.Abort()
Expand Down