Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor scheduler interface - API and inner logic #537

Merged
merged 44 commits into from Dec 29, 2022
Merged

Refactor scheduler interface - API and inner logic #537

merged 44 commits into from Dec 29, 2022

Commits on Nov 23, 2022

  1. Add flex_model & flex_context in API endpoint; refactor design for Sc… 

    …heduler implementations (moving some endpoint logic here);

Signed-off-by: Nicolas Höning <nicolas@seita.nl>
    @nhoening
    nhoening committed Nov 23, 2022
    Copy the full SHA
    274ca78 View commit details
    Browse the repository at this point in the history

  2. add new schema modules 

    Signed-off-by: Nicolas Höning <nicolas@seita.nl>
    @nhoening
    nhoening committed Nov 23, 2022
    Copy the full SHA
    814ad4a View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into refactor-scheduler-interface 

    Signed-off-by: Nicolas Höning <nicolas@seita.nl>
    @nhoening
    nhoening committed Nov 23, 2022
    Copy the full SHA
    59419e2 View commit details
    Browse the repository at this point in the history

  4. include two other flex context params in solver test 

    Signed-off-by: Nicolas Höning <nicolas@seita.nl>
    @nhoening
    nhoening committed Nov 23, 2022
    Copy the full SHA
    0cb4928 View commit details
    Browse the repository at this point in the history

Commits on Dec 10, 2022

  1. Merge branch 'main' into refactor-scheduler-interface 

    Signed-off-by: Nicolas Höning <nicolas@seita.nl>
    @nhoening
    nhoening committed Dec 10, 2022
    Copy the full SHA
    610ab2a View commit details
    Browse the repository at this point in the history

  2. also support deprecated flex_context parameters, and align spelling o… 

    …f params with underscore in docstring

Signed-off-by: Nicolas Höning <nicolas@seita.nl>
    @nhoening
    nhoening committed Dec 10, 2022
    Copy the full SHA
    2f77285 View commit details
    Browse the repository at this point in the history

  3. correctly handle flex-model validation errors when they come up in th… 

    …e endpoint

Signed-off-by: Nicolas Höning <nicolas@seita.nl>
    @nhoening
    nhoening committed Dec 10, 2022
    Copy the full SHA
    6042cd5 View commit details
    Browse the repository at this point in the history

  4. merge 

    Signed-off-by: Nicolas Höning <nicolas@seita.nl>
    @nhoening
    nhoening committed Dec 10, 2022
    Copy the full SHA
    d3911a1 View commit details
    Browse the repository at this point in the history

Commits on Dec 12, 2022

  1. changelog: add deprecation warnings and mentions this PR 

    Signed-off-by: Nicolas Höning <nicolas@seita.nl>
    @nhoening
    nhoening committed Dec 12, 2022
    Copy the full SHA
    c0cc2ce View commit details
    Browse the repository at this point in the history

  2. fix internal link 

    Signed-off-by: Nicolas Höning <nicolas@seita.nl>
    @nhoening
    nhoening committed Dec 12, 2022
    Copy the full SHA
    7d6abb7 View commit details
    Browse the repository at this point in the history

  3. move flex-model and flex-context docs to notation module; small fixes… 

    … in dummy custom scheduler

Signed-off-by: Nicolas Höning <nicolas@seita.nl>
    @nhoening
    nhoening committed Dec 12, 2022
    Copy the full SHA
    140e5be View commit details
    Browse the repository at this point in the history

Commits on Dec 13, 2022

  1. deprecate soc-sensor-id field, store soc states on the asset attribut… 

    …es in v3.0 as well, using a way that lets all schedulers save (parts of) it if they want.

Signed-off-by: Nicolas Höning <nicolas@seita.nl>
    @nhoening
    nhoening committed Dec 13, 2022
    Copy the full SHA
    af00092 View commit details
    Browse the repository at this point in the history

  2. check (and potentially fill in defaults for) soc_min and soc_max befo… 

    …re we apply the schema (which expects non-nan values here)

Signed-off-by: Nicolas Höning <nicolas@seita.nl>
    @nhoening
    nhoening committed Dec 13, 2022
    Copy the full SHA
    b87de99 View commit details
    Browse the repository at this point in the history

  3. make add schedule command work with our refactored scheduling code, s… 

    …mall refactoring to save lines

Signed-off-by: Nicolas Höning <nicolas@seita.nl>
    @nhoening
    nhoening committed Dec 13, 2022
    Copy the full SHA
    6ac5a76 View commit details
    Browse the repository at this point in the history

  4. rename the CLI command as it only represents storage right now (and w… 

    …e might choose that the CLI will be specific to our in-built flex models)

Signed-off-by: Nicolas Höning <nicolas@seita.nl>
    @nhoening
    nhoening committed Dec 13, 2022
    Copy the full SHA
    f3cf7a2 View commit details
    Browse the repository at this point in the history

Commits on Dec 14, 2022

  1. More thorough checks for passed soc-values in StorageScheduler, leads… 

    … to small fix in API endpoint and scheduling tests

Signed-off-by: Nicolas Höning <nicolas@seita.nl>
    @nhoening
    nhoening committed Dec 14, 2022
    Copy the full SHA
    8bb30f9 View commit details
    Browse the repository at this point in the history

  2. doc improvements from review 

    Signed-off-by: Nicolas Höning <nicolas@seita.nl>
    @nhoening
    nhoening committed Dec 14, 2022
    Copy the full SHA
    11633f8 View commit details
    Browse the repository at this point in the history

Commits on Dec 16, 2022

  1. Change parameter names for flex model and context which come through … 

    …the API to use hyphens, which is conventionally preferred.

Signed-off-by: Nicolas Höning <nicolas@seita.nl>
    @nhoening
    nhoening committed Dec 16, 2022
    Copy the full SHA
    b784c56 View commit details
    Browse the repository at this point in the history

  2. Make flexmeasures add schedule a subgroup (#557) 

    * Make `flexmeasuress add schedule` a subgroup:
- invoke a default subcommand
- show a deprecation warning

Signed-off-by: F.N. Claessen <felix@seita.nl>

* adapt CLI command name so it's clearer what is being added

Signed-off-by: Nicolas Höning <nicolas@seita.nl>

Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
Co-authored-by: Nicolas Höning <nicolas@seita.nl>
    @Flix6x @nhoening
    Flix6x and nhoening committed Dec 16, 2022
    Copy the full SHA
    7321019 View commit details
    Browse the repository at this point in the history

  3. add one missing documentation improvement from review 

    Signed-off-by: Nicolas Höning <nicolas@seita.nl>
    @nhoening
    nhoening committed Dec 16, 2022
    Copy the full SHA
    4bf8e55 View commit details
    Browse the repository at this point in the history

Commits on Dec 21, 2022

  1. make sure hyphens are used in flex-model to the outside world (API, CLI) 

    Signed-off-by: Nicolas Höning <nicolas@seita.nl>
    @nhoening
    nhoening committed Dec 21, 2022
    Copy the full SHA
    7231c18 View commit details
    Browse the repository at this point in the history

  2. smaller review items, mostly documentation 

    Signed-off-by: Nicolas Höning <nicolas@seita.nl>
    @nhoening
    nhoening committed Dec 21, 2022
    Copy the full SHA
    f667106 View commit details
    Browse the repository at this point in the history

Commits on Dec 25, 2022

  1. remove soc checks which added interpretation (should be part of anoth… 

    …er PR, if at all)

Signed-off-by: Nicolas Höning <nicolas@seita.nl>
    @nhoening
    nhoening committed Dec 25, 2022
    Copy the full SHA
    e06e235 View commit details
    Browse the repository at this point in the history

  2. fixes to notation docs 

    Signed-off-by: Nicolas Höning <nicolas@seita.nl>
    @nhoening
    nhoening committed Dec 25, 2022
    Copy the full SHA
    403660c View commit details
    Browse the repository at this point in the history

  3. make sure scheduling tests work on empty queues, with new fixture 

    Signed-off-by: Nicolas Höning <nicolas@seita.nl>
    @nhoening
    nhoening committed Dec 25, 2022
    Copy the full SHA
    0da3b30 View commit details
    Browse the repository at this point in the history

  4. remove two tests for previously removed util function 

    Signed-off-by: Nicolas Höning <nicolas@seita.nl>
    @nhoening
    nhoening committed Dec 25, 2022
    Copy the full SHA
    20de523 View commit details
    Browse the repository at this point in the history

  5. batch of small review comments 

    Signed-off-by: Nicolas Höning <nicolas@seita.nl>
    @nhoening
    nhoening committed Dec 25, 2022
    Copy the full SHA
    c9bc738 View commit details
    Browse the repository at this point in the history

  6. make get_data_source_info a class method of Scheduler 

    Signed-off-by: Nicolas Höning <nicolas@seita.nl>
    @nhoening
    nhoening committed Dec 25, 2022
    Copy the full SHA
    4965575 View commit details
    Browse the repository at this point in the history

  7. small simplification of get_data_source_for_job 

    Signed-off-by: Nicolas Höning <nicolas@seita.nl>
    @nhoening
    nhoening committed Dec 25, 2022
    Copy the full SHA
    fcbfad9 View commit details
    Browse the repository at this point in the history

  8. Merge branch 'main' into refactor-scheduler-interface 

    Signed-off-by: Nicolas Höning <nicolas@seita.nl>
    @nhoening
    nhoening committed Dec 25, 2022
    Copy the full SHA
    d562bf1 View commit details
    Browse the repository at this point in the history

  9. specify min/max inclusiveness of roundtrip-efficiency parameter 

    Signed-off-by: Nicolas Höning <nicolas@seita.nl>
    @nhoening
    nhoening committed Dec 25, 2022
    Copy the full SHA
    1b8ded8 View commit details
    Browse the repository at this point in the history

  10. Merge branch 'refactor-scheduler-interface' of github.com:FlexMeasure… 

    …s/flexmeasures into refactor-scheduler-interface
    @nhoening
    nhoening committed Dec 25, 2022
    Copy the full SHA
    f1bc3cb View commit details
    Browse the repository at this point in the history

Commits on Dec 27, 2022

  1. create_scheduling_jobs accepts both object and ID 

    Signed-off-by: Nicolas Höning <nicolas@seita.nl>
    @nhoening
    nhoening committed Dec 27, 2022
    Copy the full SHA
    a32b819 View commit details
    Browse the repository at this point in the history

  2. fix type hinting 

    Signed-off-by: Nicolas Höning <nicolas@seita.nl>
    @nhoening
    nhoening committed Dec 27, 2022
    Copy the full SHA
    07a21a3 View commit details
    Browse the repository at this point in the history

  3. API changelog & flex config introduction 

    Signed-off-by: Nicolas Höning <nicolas@seita.nl>
    @nhoening
    nhoening committed Dec 27, 2022
    Copy the full SHA
    0ef19fa View commit details
    Browse the repository at this point in the history

  4. two missing fixes 

    Signed-off-by: Nicolas Höning <nicolas@seita.nl>
    @nhoening
    nhoening committed Dec 27, 2022
    Copy the full SHA
    480fac9 View commit details
    Browse the repository at this point in the history

  5. remove line about previously undocumented & now depreacated line 

    Signed-off-by: Nicolas Höning <nicolas@seita.nl>
    @nhoening
    nhoening committed Dec 27, 2022
    Copy the full SHA
    658f8b5 View commit details
    Browse the repository at this point in the history

  6. Deprecation headers for old fields that moved to flex-model and flex-… 

    …context (#564)

* Add deprecation and sunset response headers when deprecated fields are used

Signed-off-by: F.N. Claessen <felix@seita.nl>

* Refactor: duplicate code becomes util function

Signed-off-by: F.N. Claessen <felix@seita.nl>

* Correct deprecation and sunset links

Signed-off-by: F.N. Claessen <felix@seita.nl>

* rename to represent plural-default of param, update link to 3.0.5 API changelog

Signed-off-by: Nicolas Höning <nicolas@seita.nl>

Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
Co-authored-by: Nicolas Höning <nicolas@seita.nl>
    @Flix6x @nhoening
    Flix6x and nhoening committed Dec 27, 2022
    Copy the full SHA
    b053994 View commit details
    Browse the repository at this point in the history

Commits on Dec 28, 2022

  1. refactor where the code lives that builds device equality constraints… 

    … from soc targets

Signed-off-by: Nicolas Höning <nicolas@seita.nl>
    @nhoening
    nhoening committed Dec 28, 2022
    Copy the full SHA
    c2b7ffa View commit details
    Browse the repository at this point in the history

  2. change a sentence in notation 

    Signed-off-by: Nicolas Höning <nicolas@seita.nl>
    @nhoening
    nhoening committed Dec 28, 2022
    Copy the full SHA
    39b82d7 View commit details
    Browse the repository at this point in the history

Commits on Dec 29, 2022

  1. Rename inspection to deserialization 

    Signed-off-by: F.N. Claessen <felix@seita.nl>
    @Flix6x
    Flix6x committed Dec 29, 2022
    Copy the full SHA
    6b26a32 View commit details
    Browse the repository at this point in the history

  2. Fix DummyScheduler in documentation 

    Signed-off-by: F.N. Claessen <felix@seita.nl>
    @Flix6x
    Flix6x committed Dec 29, 2022
    Copy the full SHA
    c8bd10a View commit details
    Browse the repository at this point in the history

  3. Simplify imports for plugin developers (also facilitates renaming the… 

    … planning module without needing plugin developers to upgrade their code)

Signed-off-by: F.N. Claessen <felix@seita.nl>
    @Flix6x
    Flix6x committed Dec 29, 2022
    Copy the full SHA
    9ad7c3d View commit details
    Browse the repository at this point in the history

  4. Resolve circular import 

    Signed-off-by: F.N. Claessen <felix@seita.nl>
    @Flix6x
    Flix6x committed Dec 29, 2022
    Copy the full SHA
    37b56f0 View commit details
    Browse the repository at this point in the history