Fix tutorial timezone #535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: F.N. Claessen <felix@seita.nl>
…nger assume utc, but raise instead (see PR #521) Signed-off-by: F.N. Claessen <felix@seita.nl>
Flix6x
added
bug
|
Doesn't need a changelog entry imo, because the bug isn't part of any release. |
Pull Request Test Coverage Report for Build 3472345941
💛 - Coveralls |
nhoening
approved these changes
Nov 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for changed default when reading in timezone naive data: we no longer assume utc, but raise instead (since PR #521).
I also updated the sensor name mentioned in the tutorial.
For 0.13.0, I'm making a larger pass at the tutorial in #534 (for example, setting the timezone to Europe/Amsterdam, which I feel makes more sense in this example). But here I just want to fix a broken tutorial before we release 0.12.0, so I'm sticking with utc.