Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix asset display when asset has no owner #514

Merged
merged 2 commits into from Oct 13, 2022
Merged

fix asset display when asset has no owner #514

merged 2 commits into from Oct 13, 2022

Conversation

nhoening
Copy link
Contributor

fixes #513

@nhoening
fix asset display when asset has no owner
ceed4ff 
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
@nhoening nhoening added this to the 0.12.0 milestone Oct 13, 2022
@nhoening nhoening requested a review from Flix6x October 13, 2022 13:45
@coveralls
Copy link
Collaborator

coveralls commented Oct 13, 2022 •
edited

Pull Request Test Coverage Report for Build 3243337590

  • 0 of 3 (0.0%) changed or added relevant lines in 1 file are covered.
  • 31 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.03%) to 64.969%
Changes Missing Coverage Covered Lines Changed/Added Lines %
flexmeasures/data/services/sensors.py 0 3 0.0%
Files with Coverage Reduction New Missed Lines %
flexmeasures/data/services/sensors.py 1 15.63%
flexmeasures/data/models/charts/belief_charts.py 9 12.77%
flexmeasures/data/models/generic_assets.py 21 47.18%
Totals Coverage Status
Change from base Build 3230159004: -0.03%
Covered Lines: 6479
Relevant Lines: 9363
💛 - Coveralls

Flix6x
Flix6x approved these changes Oct 13, 2022
View reviewed changes
flexmeasures/data/services/sensors.py Outdated Show resolved Hide resolved
@nhoening
more modern typing of Optional
080c055 
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
@nhoening nhoening merged commit 35ede27 into main Oct 13, 2022
@nhoening nhoening deleted the issue-513-display-asset-with-no-owner branch October 13, 2022 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Flix6x Flix6x Flix6x approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.12.0
Development

Successfully merging this pull request may close these issues.

AttributeError when displaying an asset which has only public sensors
3 participants
@nhoening @coveralls @Flix6x