Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 499 allow showing sensor data from other assets in the same account #500

Merged
merged 18 commits into from Oct 11, 2022
Merged

Issue 499 allow showing sensor data from other assets in the same account #500

merged 18 commits into from Oct 11, 2022

Commits on Sep 12, 2022

  1. Make it possible to show sensor data from other assets in the same ac… 

    …count

Signed-off-by: F.N. Claessen <felix@seita.nl>
    @Flix6x
    Flix6x committed Sep 12, 2022
    Copy the full SHA
    d328236 View commit details
    Browse the repository at this point in the history

  2. Expand docstring 

    Signed-off-by: F.N. Claessen <felix@seita.nl>
    @Flix6x
    Flix6x committed Sep 12, 2022
    Copy the full SHA
    4167241 View commit details
    Browse the repository at this point in the history

  3. changelog entry 

    Signed-off-by: F.N. Claessen <felix@seita.nl>
    @Flix6x
    Flix6x committed Sep 12, 2022
    Copy the full SHA
    cb37002 View commit details
    Browse the repository at this point in the history

  4. Refactor util function to get sensors for a given account (Account, i… 

    …d or name), and avoid duplicate queries of a known account

Signed-off-by: F.N. Claessen <felix@seita.nl>
    @Flix6x
    Flix6x committed Sep 12, 2022
    Copy the full SHA
    fb40536 View commit details
    Browse the repository at this point in the history

  5. Sensors on a given asset are a subset of sensors on assets with the s… 

    …ame owner

Signed-off-by: F.N. Claessen <felix@seita.nl>
    @Flix6x
    Flix6x committed Sep 12, 2022
    Copy the full SHA
    386e78a View commit details
    Browse the repository at this point in the history

  6. Limit query to requested sensor ids (instead of returning all sensors… 

    … from the same account, which may be a lot)

Signed-off-by: F.N. Claessen <felix@seita.nl>
    @Flix6x
    Flix6x committed Sep 12, 2022
    Copy the full SHA
    4bcfdf1 View commit details
    Browse the repository at this point in the history

  7. flake8 

    Signed-off-by: F.N. Claessen <felix@seita.nl>
    @Flix6x
    Flix6x committed Sep 12, 2022
    Copy the full SHA
    983becf View commit details
    Browse the repository at this point in the history

  8. Merge remote-tracking branch 'origin/main' into issue-499_Allow_showi… 

    …ng_sensor_data_from_other_assets_in_the_same_account

# Conflicts:
#	documentation/changelog.rst
    @Flix6x
    Flix6x committed Sep 12, 2022
    Copy the full SHA
    962ad22 View commit details
    Browse the repository at this point in the history

  9. Remove redundant if statement 

    Signed-off-by: F.N. Claessen <felix@seita.nl>
    @Flix6x
    Flix6x committed Sep 12, 2022
    Copy the full SHA
    0993e34 View commit details
    Browse the repository at this point in the history

  10. Refactor: rename function 

    Signed-off-by: F.N. Claessen <felix@seita.nl>
    @Flix6x
    Flix6x committed Sep 12, 2022
    Copy the full SHA
    fe2479a View commit details
    Browse the repository at this point in the history

  11. Repurpose function by making it mandatory to pass at least one accoun… 

    …t, or None for public sensors (which makes get_public_sensors obsolete)

Signed-off-by: F.N. Claessen <felix@seita.nl>
    @Flix6x
    Flix6x committed Sep 12, 2022
    Copy the full SHA
    9b6fec9 View commit details
    Browse the repository at this point in the history

  12. Partially revert repurposing function: passing accounts is optional a… 

    …gain, and rename filter argument

Signed-off-by: F.N. Claessen <felix@seita.nl>
    @Flix6x
    Flix6x committed Sep 12, 2022
    Copy the full SHA
    327b6d8 View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2022

  1. Allow to filter sensors by name 

    Signed-off-by: F.N. Claessen <felix@seita.nl>
    @Flix6x
    Flix6x committed Oct 9, 2022
    Copy the full SHA
    2546bca View commit details
    Browse the repository at this point in the history

  2. Explicit parameter for including sensors of public assets 

    Signed-off-by: F.N. Claessen <felix@seita.nl>
    @Flix6x
    Flix6x committed Oct 9, 2022
    Copy the full SHA
    d643072 View commit details
    Browse the repository at this point in the history

  3. Must pass a list of accounts 

    Signed-off-by: F.N. Claessen <felix@seita.nl>
    @Flix6x
    Flix6x committed Oct 9, 2022
    Copy the full SHA
    433102b View commit details
    Browse the repository at this point in the history

  4. The more common use case is looking up sensors for a single account 

    Signed-off-by: F.N. Claessen <felix@seita.nl>
    @Flix6x
    Flix6x committed Oct 9, 2022
    Copy the full SHA
    a0a0379 View commit details
    Browse the repository at this point in the history

  5. Rename variable 

    Signed-off-by: F.N. Claessen <felix@seita.nl>
    @Flix6x
    Flix6x committed Oct 9, 2022
    Copy the full SHA
    0ab4dab View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2022

  1. fix variable order 

    Signed-off-by: F.N. Claessen <felix@seita.nl>
    @Flix6x
    Flix6x committed Oct 10, 2022
    Copy the full SHA
    f547cdd View commit details
    Browse the repository at this point in the history