Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ACL-based auth policy and the @permission_required_for_context decorator. For now used with /users API #234

Merged
merged 24 commits into from Nov 24, 2021
Merged

ACL-based auth policy and the @permission_required_for_context decorator. For now used with /users API #234

merged 24 commits into from Nov 24, 2021

Commits on Nov 9, 2021

  1. first implementation of ACL-based auth policy and the @permission_req… 

    …uired_for_context decorator. Used for one /user endpoint (GET /user/<id>)
    @nhoening
    nhoening committed Nov 9, 2021
    Copy the full SHA
    ec93cc7 View commit details
    Browse the repository at this point in the history

  2. make GET /users and PATCH /user/<id> work. Inn the process simplifyin… 

    …g /users to work for one account only, and moving API context factories to a common location
    @nhoening
    nhoening committed Nov 9, 2021
    Copy the full SHA
    977dc82 View commit details
    Browse the repository at this point in the history

  3. resolve circular import

    @nhoening
    nhoening committed Nov 9, 2021
    Copy the full SHA
    cab6083 View commit details
    Browse the repository at this point in the history

  4. always log the authorization failure for debugging purposes

    @nhoening
    nhoening committed Nov 9, 2021
    Copy the full SHA
    16ea49c View commit details
    Browse the repository at this point in the history

  5. adapt UI crud so it lists users from all accounts again after API sim… 

    …plification
    @nhoening
    nhoening committed Nov 9, 2021
    Copy the full SHA
    e46c9f0 View commit details
    Browse the repository at this point in the history

  6. check for valid permissions and allow the ADMIN_READER role to read

    @nhoening
    nhoening committed Nov 9, 2021
    Copy the full SHA
    158a945 View commit details
    Browse the repository at this point in the history

Commits on Nov 10, 2021

  1. separate checking admin access and principals within policy, add test… 

    …s for principals matching
    @nhoening
    nhoening committed Nov 10, 2021
    Copy the full SHA
    c33f982 View commit details
    Browse the repository at this point in the history

  2. changelog entry

    @nhoening
    nhoening committed Nov 10, 2021
    Copy the full SHA
    d65f85f View commit details
    Browse the repository at this point in the history

  3. fix test

    @nhoening
    nhoening committed Nov 10, 2021
    Copy the full SHA
    a6acf8d View commit details
    Browse the repository at this point in the history

Commits on Nov 11, 2021

  1. Add test for multiple roles and multiple account roles

    @Flix6x
    Flix6x committed Nov 11, 2021
    Copy the full SHA
    8734e8d View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2021

  1. smaller haul from review

    @nhoening
    nhoening committed Nov 15, 2021
    Copy the full SHA
    1da1a6e View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2021

  1. replace deprecated marshmallow parameters

    @nhoening
    nhoening committed Nov 16, 2021
    Copy the full SHA
    fff7705 View commit details
    Browse the repository at this point in the history

  2. explicitly require marshmallow>3 as we use recent parameters (app.txt… 

    … already pins it >3)
    @nhoening
    nhoening committed Nov 16, 2021
    Copy the full SHA
    0a0c250 View commit details
    Browse the repository at this point in the history

  3. replace load_account with Marshmallow field; enable the permission-ch… 

    …ecking decorator to get the resource from keyword args
    @nhoening
    nhoening committed Nov 16, 2021
    Copy the full SHA
    9588501 View commit details
    Browse the repository at this point in the history

  4. move load_user factory to marshmallow field, as well; refactor permis… 

    …sion decorator a bit
    @nhoening
    nhoening committed Nov 16, 2021
    Copy the full SHA
    0ef64a1 View commit details
    Browse the repository at this point in the history

Commits on Nov 17, 2021

  1. update documentation

    @nhoening
    nhoening committed Nov 17, 2021
    5
    Copy the full SHA
    2aaeb70 View commit details
    Browse the repository at this point in the history

  2. permissions: use update over write (-> CRUD)

    @nhoening
    nhoening committed Nov 17, 2021
    Copy the full SHA
    7bb46e8 View commit details
    Browse the repository at this point in the history

  3. use @auth_required in place of @login_required in non-user-facing end… 

    …points
    @nhoening
    nhoening committed Nov 17, 2021
    Copy the full SHA
    c6f8300 View commit details
    Browse the repository at this point in the history

Commits on Nov 20, 2021

  1. doc improvements from review

    @nhoening
    nhoening committed Nov 20, 2021
    Copy the full SHA
    58e6ab5 View commit details
    Browse the repository at this point in the history

  2. nicer way to state conditions for account roles decorators

    @nhoening
    nhoening committed Nov 20, 2021
    Copy the full SHA
    670bc1d View commit details
    Browse the repository at this point in the history

  3. Typo

    @Flix6x
    Flix6x committed Nov 20, 2021
    Copy the full SHA
    8637d48 View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2021

  1. Auth decorators raise 403/401, simplify invalid_sender

    @nhoening
    nhoening committed Nov 22, 2021
    Copy the full SHA
    6f4af62 View commit details
    Browse the repository at this point in the history

Commits on Nov 23, 2021

  1. Add type annotation

    @Flix6x
    Flix6x committed Nov 23, 2021
    Copy the full SHA
    fe84e6e View commit details
    Browse the repository at this point in the history

  2. nicer error messages in auth decorators

    @nhoening
    nhoening committed Nov 23, 2021
    Copy the full SHA
    782569b View commit details
    Browse the repository at this point in the history