Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix] skip conversion of SOC targets minima or maxima are defined as Sensors #1047

Merged
merged 8 commits into from May 6, 2024
Merged

[fix] skip conversion of SOC targets minima or maxima are defined as Sensors #1047

merged 8 commits into from May 6, 2024

Conversation

victorgarcia98
Copy link
Contributor

@victorgarcia98 victorgarcia98 commented Apr 25, 2024 •
edited

TODO

  • Add an end-to-end test that uses these three parameters as sensors.
  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on code under GPL or other license that is incompatible with FlexMeasures

@victorgarcia98
fix: skip conversion of soc_targets, soc_minima and soc_maxima if the…
16d3d99 
…y are defined from sensors.

Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
@victorgarcia98 victorgarcia98 self-assigned this Apr 25, 2024
@victorgarcia98
add test
e4818bd 
Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
@victorgarcia98 victorgarcia98 marked this pull request as ready for review May 2, 2024 21:08
@victorgarcia98 victorgarcia98 requested a review from Flix6x May 2, 2024 21:08
@Flix6x Flix6x added this to the 0.20.1 milestone May 6, 2024
Flix6x added 5 commits May 6, 2024 11:43
@Flix6x
style: small review fixes
f5baaad 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
fix: remove confusing attribute for SoC sensors
3536f31 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
docs: clarify fixture
3b9269e 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
docs: changelog entry
007145a 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
Merge remote-tracking branch 'refs/remotes/origin/main' into fix/plan…
24bd4b7 
…ning/skip-conversion-when-soc-target-maxima-minima-are-sensors
@Flix6x Flix6x added Units Deals with unit conversion and removed Still Needs Changelog Entry labels May 6, 2024
@Flix6x Flix6x merged commit db69234 into main May 6, 2024
7 checks passed
@Flix6x Flix6x deleted the fix/planning/skip-conversion-when-soc-target-maxima-minima-are-sensors branch May 6, 2024 10:04
Flix6x pushed a commit that referenced this pull request May 6, 2024
@victorgarcia98 @Flix6x
Backport PR #1047: [fix] skip conversion of SOC targets minima or max…
b825555 
…ima are defined as Sensors (#1047)

* fix: skip conversion of soc_targets, soc_minima and soc_maxima if they are defined from sensors.

Signed-off-by: Victor Garcia Reolid <victor@seita.nl>

* add test

Signed-off-by: Victor Garcia Reolid <victor@seita.nl>

* style: small review fixes

Signed-off-by: F.N. Claessen <felix@seita.nl>

* fix: remove confusing attribute for SoC sensors

Signed-off-by: F.N. Claessen <felix@seita.nl>

* docs: clarify fixture

Signed-off-by: F.N. Claessen <felix@seita.nl>

* docs: changelog entry

Signed-off-by: F.N. Claessen <felix@seita.nl>

---------

Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Co-authored-by: F.N. Claessen <felix@seita.nl>
(cherry picked from commit db69234)
Flix6x pushed a commit that referenced this pull request May 7, 2024
@victorgarcia98 @Flix6x
Backport PR #1047: [fix] skip conversion of SOC targets minima or max…
346360c 
…ima are defined as Sensors (#1047)

* fix: skip conversion of soc_targets, soc_minima and soc_maxima if they are defined from sensors.

Signed-off-by: Victor Garcia Reolid <victor@seita.nl>

* add test

Signed-off-by: Victor Garcia Reolid <victor@seita.nl>

* style: small review fixes

Signed-off-by: F.N. Claessen <felix@seita.nl>

* fix: remove confusing attribute for SoC sensors

Signed-off-by: F.N. Claessen <felix@seita.nl>

* docs: clarify fixture

Signed-off-by: F.N. Claessen <felix@seita.nl>

* docs: changelog entry

Signed-off-by: F.N. Claessen <felix@seita.nl>

---------

Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Co-authored-by: F.N. Claessen <felix@seita.nl>
(cherry picked from commit db69234)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Flix6x Flix6x Flix6x approved these changes

Assignees

@victorgarcia98 victorgarcia98

Labels
Scheduling Units Deals with unit conversion
Projects
None yet
Milestone
0.20.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@victorgarcia98 @Flix6x