Feature/save soc values as a sensor #1018
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ahmad Wahid <ahmedwahid16101@gmail.com>
Signed-off-by: Ahmad Wahid <ahmedwahid16101@gmail.com>
Signed-off-by: Ahmad Wahid <ahmedwahid16101@gmail.com>
…-soc-values-as-a-sensor # Conflicts: # flexmeasures/data/models/planning/tests/test_solver.py
Signed-off-by: Ahmad Wahid <ahmedwahid16101@gmail.com>
nhoening
reviewed
Apr 5, 2024
Ahmad-Wahid
commented
Apr 5, 2024
Flix6x
requested changes
Apr 6, 2024
flexmeasures/data/schemas/sensors.py
Outdated
Comment on lines
245
to
260
| try: | ||
| float(value) | ||
| return value | ||
| except ValueError: | ||
| pass | ||
| return ur.Quantity(value).to(self.to_unit) | ||
| except DimensionalityError as e: | ||
| raise FMValidationError( | ||
| f"Cannot convert value `{value}` to '{self.to_unit}'" | ||
| ) from e | ||
| elif ( | ||
| isinstance(value, Sensor) | ||
| or isinstance(value, int) | ||
| or isinstance(value, float) | ||
| ): | ||
| return value |
There was a problem hiding this comment.
I don't think we'll need changes to this schema for now. SoC values passed to the new field should be sensor descriptions ({"sensor": <id>}) or strings containing a unit that is convertible to MWh (e.g. "50 kWh").
There was a problem hiding this comment.
The flex model gets SoC sensor and not a dictionay . So I still need to have a check for sensor as value.
There was a problem hiding this comment.
What do you think about this change?
…-soc-values-as-a-sensor
Signed-off-by: Ahmad Wahid <ahmedwahid16101@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces
create_soc_schedule, a function to generate a state of charge (SOC) schedule from provided data. It also handles the creation or retrieval of the corresponding SOC sensor.Look & Feel
UI output looks like this:
How to test
Try to run the Toy examples(1 and 2), first add the beliefs from here and then add the schedule from here. You will see a sensor with name
soc scheduleand id4. Similarly, you can see the data intimed_beliefstable.Further Improvements
Potential improvements to be done in the same PR or follow up Issues/Discussions/PRs.
Related Items
Mention if this PR closes an Issue or Project.